Re: Review Request 35927: Added TaskStatus::Reason to Termination Message.

2015-07-10 Thread Jie Yu
On June 29, 2015, 7:40 p.m., Jie Yu wrote: Thanks Joerg! See my detailed comments. I suggest you take a look at the discussion in https://reviews.apache.org/r/34720/ first. Hi Joerg, I am wondering if you are still working on this ticket? Some of our internal framework developers noticed

Re: Review Request 35927: Added TaskStatus::Reason to Termination Message.

2015-06-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35927/ --- (Updated June 29, 2015, 7:22 a.m.) Review request for mesos and Alexander

Re: Review Request 35927: Added TaskStatus::Reason to Termination Message.

2015-06-29 Thread Alexander Rukletsov
On June 28, 2015, 8:57 a.m., Alexander Rukletsov wrote: include/mesos/containerizer/containerizer.proto, lines 87-89 https://reviews.apache.org/r/35927/diff/1/?file=993029#file993029line87 Why do we need a deprecation cycle for this? AFAIK, it's part of the containerizer API only

Re: Review Request 35927: Added TaskStatus::Reason to Termination Message.

2015-06-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35927/#review89717 --- Patch looks great! Reviews applied: [35927] All tests passed. -

Re: Review Request 35927: Added TaskStatus::Reason to Termination Message.

2015-06-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35927/#review89779 --- Thanks Joerg! See my detailed comments. I suggest you take a look

Re: Review Request 35927: Added TaskStatus::Reason to Termination Message.

2015-06-28 Thread Joerg Schad
On June 28, 2015, 8:57 a.m., Alexander Rukletsov wrote: include/mesos/slave/isolator.hpp, line 64 https://reviews.apache.org/r/35927/diff/1/?file=993031#file993031line64 AFAIK, techinally, limitation does not necessarily end in termination, though it is so for

Re: Review Request 35927: Added TaskStatus::Reason to Termination Message.

2015-06-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35927/#review89667 --- include/mesos/containerizer/containerizer.proto (lines 87 - 89)

Review Request 35927: Added TaskStatus::Reason to Termination Message.

2015-06-26 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35927/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-2035

Re: Review Request 35927: Added TaskStatus::Reason to Termination Message.

2015-06-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35927/#review89518 --- Patch looks great! Reviews applied: [35927] All tests passed. -