Re: Review Request 35961: Include protobuf classes in generated Javadoc.

2015-07-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35961/#review90969 --- Any plan to get this onto the website? - Ben Mahler On June 29,

Re: Review Request 35961: Include protobuf classes in generated Javadoc.

2015-07-08 Thread Adam B
On July 8, 2015, 12:38 p.m., Ben Mahler wrote: Any plan to get this onto the website? Unfortunately, our website build/deploy Rakefile doesn't use the standard maven way to generate javadoc, and just runs the javadoc command manually. See https://issues.apache.org/jira/browse/MESOS-2959

Re: Review Request 35961: Include protobuf classes in generated Javadoc.

2015-06-29 Thread Connor Doyle
On June 27, 2015, 6:59 p.m., Adam B wrote: src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in, lines 27-36 https://reviews.apache.org/r/35961/diff/1/?file=993816#file993816line27 Did you verify that the curly-braces are properly handled here? I read on

Re: Review Request 35961: Include protobuf classes in generated Javadoc.

2015-06-29 Thread Connor Doyle
On June 27, 2015, 6:59 p.m., Adam B wrote: Thanks for doing this Connor! Just a couple of questions about javadoc parsing of html (I'm no expert, just googled a few things). Do we need to do a pass over our protos now to convert any `//` or `/*` block comments to `/**` comments? Worth

Re: Review Request 35961: Include protobuf classes in generated Javadoc.

2015-06-29 Thread Connor Doyle
On June 27, 2015, 6:59 p.m., Adam B wrote: src/java/mesos.pom.in, line 134 https://reviews.apache.org/r/35961/diff/1/?file=993817#file993817line134 Is `${project.basedir}/generated` any better/different than `@abs_top_builddir@/src/java/generated` Connor Doyle wrote:

Re: Review Request 35961: Include protobuf classes in generated Javadoc.

2015-06-29 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35961/#review89839 --- Ship it! Ship It! - Adam B On June 29, 2015, 8:53 a.m., Connor

Review Request 35961: Include protobuf classes in generated Javadoc.

2015-06-26 Thread Connor Doyle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35961/ --- Review request for mesos, Adam B and Ben Whitehead. Bugs: MESOS-1552

Re: Review Request 35961: Include protobuf classes in generated Javadoc.

2015-06-26 Thread Ben Whitehead
On June 26, 2015, 6:30 p.m., Ben Whitehead wrote: Ship It! Downloaded patch, applied, configure make, Manual Verification. - Ben --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 35961: Include protobuf classes in generated Javadoc.

2015-06-26 Thread Ben Whitehead
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35961/#review89605 --- Ship it! Ship It! - Ben Whitehead On June 26, 2015, 6:18 p.m.,