Re: Review Request 36056: Add test cases to check the ownership of persistent volume.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36056/#review90003 --- Patch looks great! Reviews applied: [36056] All tests passed. - Mesos ReviewBot On June 30, 2015, 4:53 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36056/ --- (Updated June 30, 2015, 4:53 p.m.) Review request for mesos, Adam B and Jie Yu. Bugs: MESOS-2603 https://issues.apache.org/jira/browse/MESOS-2603 Repository: mesos Description --- Add test cases to check the ownership of persistent volume. Diffs - src/tests/environment.cpp f111a77c3ca6a508aa91e91db7fa10c72f27d26b src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3 src/tests/mesos.cpp 5eab6dea6058865847425ab8d31708c92c6f098a src/tests/persistent_volume_tests.cpp c5f72d5b7a118eb121e268f982955c73159a61e1 src/tests/slave_tests.cpp 4ddc608ab9636fcc0166e8c80a252dcf67b45ad3 Diff: https://reviews.apache.org/r/36056/diff/ Testing --- make check Hi, @adam-mesos, @jieyu. Sorry for add test cases not with this [r35721](https://reviews.apache.org/r/35721/). In this patch, I add two test cases. One for verify ownership when we set framework.user and not set command.user, the other one verify ownership when set framework.user and command.user both. I also switch the SlaveTest.ROOT_RunTaskWithCommandInfoWithUser to the way that @adam-mesos suggest in [r35728](https://reviews.apache.org/r/35728/). Because the new test cases also need prepare the binaries when they run under a different user 'nobody'. Thanks, haosdent huang
Re: Review Request 36056: Add test cases to check the ownership of persistent volume.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36056/ --- (Updated June 30, 2015, 4:53 p.m.) Review request for mesos, Adam B and Jie Yu. Bugs: MESOS-2603 https://issues.apache.org/jira/browse/MESOS-2603 Repository: mesos Description --- Add test cases to check the ownership of persistent volume. Diffs (updated) - src/tests/environment.cpp f111a77c3ca6a508aa91e91db7fa10c72f27d26b src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3 src/tests/mesos.cpp 5eab6dea6058865847425ab8d31708c92c6f098a src/tests/persistent_volume_tests.cpp c5f72d5b7a118eb121e268f982955c73159a61e1 src/tests/slave_tests.cpp 4ddc608ab9636fcc0166e8c80a252dcf67b45ad3 Diff: https://reviews.apache.org/r/36056/diff/ Testing --- make check Hi, @adam-mesos, @jieyu. Sorry for add test cases not with this [r35721](https://reviews.apache.org/r/35721/). In this patch, I add two test cases. One for verify ownership when we set framework.user and not set command.user, the other one verify ownership when set framework.user and command.user both. I also switch the SlaveTest.ROOT_RunTaskWithCommandInfoWithUser to the way that @adam-mesos suggest in [r35728](https://reviews.apache.org/r/35728/). Because the new test cases also need prepare the binaries when they run under a different user 'nobody'. Thanks, haosdent huang
Review Request 36056: Add test cases to check the ownership of persistent volume.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36056/ --- Review request for mesos, Adam B and Jie Yu. Bugs: MESOS-2603 https://issues.apache.org/jira/browse/MESOS-2603 Repository: mesos Description --- Add test cases to check the ownership of persistent volume. Diffs - src/tests/environment.cpp f111a77c3ca6a508aa91e91db7fa10c72f27d26b src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3 src/tests/mesos.cpp 5eab6dea6058865847425ab8d31708c92c6f098a src/tests/persistent_volume_tests.cpp c5f72d5b7a118eb121e268f982955c73159a61e1 src/tests/slave_tests.cpp 4ddc608ab9636fcc0166e8c80a252dcf67b45ad3 Diff: https://reviews.apache.org/r/36056/diff/ Testing --- make check Hi, @adam-mesos, @jieyu. Sorry for add test cases not with this [r35721](https://reviews.apache.org/r/35721/). In this patch, I add two test cases. One for verify ownership when we set framework.user and not set command.user, the other one verify ownership when set framework.user and command.user both. I also switch the SlaveTest.ROOT_RunTaskWithCommandInfoWithUser to the way that @adam-mesos suggest in [r35728](https://reviews.apache.org/r/35728/). Because the new test cases also need prepare the binaries when they run under a different user 'nobody'. Thanks, haosdent huang
