Re: Review Request 36189: Add strings::Mode to strings::trim.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36189/#review90512 --- Ship it! Ship It! - Vinod Kone On July 6, 2015, 3:29 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36189/ --- (Updated July 6, 2015, 3:29 p.m.) Review request for mesos, Artem Harutyunyan and Vinod Kone. Bugs: MESOS-2862 https://issues.apache.org/jira/browse/MESOS-2862 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 963029bea989a68a484f7b8b47d29ea5fffeb955 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 9733b2ec5d68605b694210c66144b8d9f8c36467 Diff: https://reviews.apache.org/r/36189/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 36189: Add strings::Mode to strings::trim.
On July 6, 2015, 1:53 p.m., Artem Harutyunyan wrote: Ship It! Thanks for taking care of this! - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36189/#review90558 --- On July 6, 2015, 8:29 a.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36189/ --- (Updated July 6, 2015, 8:29 a.m.) Review request for mesos, Artem Harutyunyan and Vinod Kone. Bugs: MESOS-2862 https://issues.apache.org/jira/browse/MESOS-2862 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 963029bea989a68a484f7b8b47d29ea5fffeb955 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 9733b2ec5d68605b694210c66144b8d9f8c36467 Diff: https://reviews.apache.org/r/36189/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 36189: Add strings::Mode to strings::trim.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36189/#review90558 --- Ship it! Ship It! - Artem Harutyunyan On July 6, 2015, 8:29 a.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36189/ --- (Updated July 6, 2015, 8:29 a.m.) Review request for mesos, Artem Harutyunyan and Vinod Kone. Bugs: MESOS-2862 https://issues.apache.org/jira/browse/MESOS-2862 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 963029bea989a68a484f7b8b47d29ea5fffeb955 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 9733b2ec5d68605b694210c66144b8d9f8c36467 Diff: https://reviews.apache.org/r/36189/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 36189: Add strings::Mode to strings::trim.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36189/ --- (Updated July 6, 2015, 3:29 p.m.) Review request for mesos, Artem Harutyunyan and Vinod Kone. Bugs: MESOS-2862 https://issues.apache.org/jira/browse/MESOS-2862 Repository: mesos Description --- See summary. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 963029bea989a68a484f7b8b47d29ea5fffeb955 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 9733b2ec5d68605b694210c66144b8d9f8c36467 Diff: https://reviews.apache.org/r/36189/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 36189: Add strings::Mode to strings::trim.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36189/#review90427 --- Bad patch! Reviews applied: [36189] Failed command: ./support/apply-review.sh -n -r 36189 Error: 2015-07-06 02:59:44 URL:https://reviews.apache.org/r/36189/diff/raw/ [103284/103284] - 36189.patch [1] Successfully applied: Add strings::Mode to strings::trim. See summary. Review: https://reviews.apache.org/r/36189 Checking 23 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo Total errors found: 0 ERROR: Commit spanning multiple projects. Please use separate commits for mesos, libprocess and stout. Paths grouped by project: mesos: docs/mesos-ssl.md include/mesos/mesos.proto include/mesos/scheduler/scheduler.proto src/Makefile.am src/common/protobuf_utils.cpp src/common/type_utils.cpp src/docker/docker.cpp src/examples/event_call_framework.cpp src/examples/low_level_scheduler_libprocess.cpp src/examples/low_level_scheduler_pthread.cpp src/master/master.cpp src/master/master.hpp src/sched/sched.cpp src/scheduler/scheduler.cpp src/tests/docker_tests.cpp src/tests/event_call_framework_test.sh src/tests/examples_tests.cpp src/tests/low_level_scheduler_libprocess_test.sh src/tests/low_level_scheduler_pthread_test.sh src/tests/master_tests.cpp src/tests/scheduler_tests.cpp libprocess: 3rdparty/libprocess/include/process/firewall.hpp 3rdparty/libprocess/include/process/http.hpp 3rdparty/libprocess/src/libevent.cpp 3rdparty/libprocess/src/libevent_ssl_socket.cpp 3rdparty/libprocess/src/libevent_ssl_socket.hpp 3rdparty/libprocess/src/openssl.cpp 3rdparty/libprocess/src/process.cpp 3rdparty/libprocess/src/tests/ssl_tests.cpp stout: 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp Failed to commit patch - Mesos ReviewBot On July 6, 2015, 2:56 a.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36189/ --- (Updated July 6, 2015, 2:56 a.m.) Review request for mesos, Artem Harutyunyan and Vinod Kone. Bugs: MESOS-2862 https://issues.apache.org/jira/browse/MESOS-2862 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 963029bea989a68a484f7b8b47d29ea5fffeb955 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 9733b2ec5d68605b694210c66144b8d9f8c36467 3rdparty/libprocess/include/process/firewall.hpp 692e065f2744f38035d81c0137760d996a295df6 3rdparty/libprocess/include/process/http.hpp 2f89e7ae430bb7af7bb2616758651e1614232820 3rdparty/libprocess/src/libevent.cpp 67e7501cbd5f7b374cb3037c3483c6d8aa5cc587 3rdparty/libprocess/src/libevent_ssl_socket.hpp 11c1b70fc5b96cd10f773cceb9f344ff613cc857 3rdparty/libprocess/src/libevent_ssl_socket.cpp 9424dd421b290bec25b4a7c4dc0071ffef6fdc5e 3rdparty/libprocess/src/openssl.cpp 118ce55d4b0ee1735648552e01ce16920db78d51 3rdparty/libprocess/src/process.cpp 883776a6d87f3f14d04e2d574b0e0baa469af579 3rdparty/libprocess/src/tests/ssl_tests.cpp 869ed6572392e3cdcf0c0152bcca4b91130e3c04 docs/mesos-ssl.md bb218492df90c922bc4955daeca5513ba9d18633 include/mesos/mesos.proto 3dd4a5b7a4b3bc56bdc690d6adf05f88c0d28273 include/mesos/scheduler/scheduler.proto a027da255563c620fa3d7355ad47aa16d2264f77 src/Makefile.am addb63f615f16ae6b25f745b2e79fd9fc0e27851 src/common/protobuf_utils.cpp 8a51daa45db312ca4608dda3fd99df2c3f9962f1 src/common/type_utils.cpp 19f79b47539ab51a5dff97f381a44c679cf5ecaf src/docker/docker.cpp 235ac4a093b2c23a15f2de43780f93c054ddcc4f src/examples/event_call_framework.cpp 17fdcac44c0a51293a318ef5184f4d48a461abd9 src/examples/low_level_scheduler_pthread.cpp PRE-CREATION src/master/master.hpp fb4d6fac85e284987ec8fbf6949b5023875573fb src/master/master.cpp c5a4875f0d43c5091ae9a52c6b1d04105dfa3914 src/sched/sched.cpp a748686dfc6bff39d81fd7adbd5cce88ddaaa73d src/scheduler/scheduler.cpp d5ac04cb4549e5ef886ff3c01fff414083a63c06 src/tests/docker_tests.cpp a4a2725c05ae0cb88426c587f7ded0da77154edc src/tests/event_call_framework_test.sh e42c4e8364076a408b33c894f1f3c6a21e12d1dc src/tests/examples_tests.cpp 3f56b30d8d5e2c7257f0499dc2f5ea61a7348633
Review Request 36189: Add strings::Mode to strings::trim.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36189/ --- Review request for mesos and Artem Harutyunyan. Bugs: MESOS-2862 https://issues.apache.org/jira/browse/MESOS-2862 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 963029bea989a68a484f7b8b47d29ea5fffeb955 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 9733b2ec5d68605b694210c66144b8d9f8c36467 3rdparty/libprocess/include/process/firewall.hpp 692e065f2744f38035d81c0137760d996a295df6 3rdparty/libprocess/include/process/http.hpp 2f89e7ae430bb7af7bb2616758651e1614232820 3rdparty/libprocess/src/libevent.cpp 67e7501cbd5f7b374cb3037c3483c6d8aa5cc587 3rdparty/libprocess/src/libevent_ssl_socket.hpp 11c1b70fc5b96cd10f773cceb9f344ff613cc857 3rdparty/libprocess/src/libevent_ssl_socket.cpp 9424dd421b290bec25b4a7c4dc0071ffef6fdc5e 3rdparty/libprocess/src/openssl.cpp 118ce55d4b0ee1735648552e01ce16920db78d51 3rdparty/libprocess/src/process.cpp 883776a6d87f3f14d04e2d574b0e0baa469af579 3rdparty/libprocess/src/tests/ssl_tests.cpp 869ed6572392e3cdcf0c0152bcca4b91130e3c04 docs/mesos-ssl.md bb218492df90c922bc4955daeca5513ba9d18633 include/mesos/mesos.proto 3dd4a5b7a4b3bc56bdc690d6adf05f88c0d28273 include/mesos/scheduler/scheduler.proto a027da255563c620fa3d7355ad47aa16d2264f77 src/Makefile.am addb63f615f16ae6b25f745b2e79fd9fc0e27851 src/common/protobuf_utils.cpp 8a51daa45db312ca4608dda3fd99df2c3f9962f1 src/common/type_utils.cpp 19f79b47539ab51a5dff97f381a44c679cf5ecaf src/docker/docker.cpp 235ac4a093b2c23a15f2de43780f93c054ddcc4f src/examples/event_call_framework.cpp 17fdcac44c0a51293a318ef5184f4d48a461abd9 src/examples/low_level_scheduler_pthread.cpp PRE-CREATION src/master/master.hpp fb4d6fac85e284987ec8fbf6949b5023875573fb src/master/master.cpp c5a4875f0d43c5091ae9a52c6b1d04105dfa3914 src/sched/sched.cpp a748686dfc6bff39d81fd7adbd5cce88ddaaa73d src/scheduler/scheduler.cpp d5ac04cb4549e5ef886ff3c01fff414083a63c06 src/tests/docker_tests.cpp a4a2725c05ae0cb88426c587f7ded0da77154edc src/tests/event_call_framework_test.sh e42c4e8364076a408b33c894f1f3c6a21e12d1dc src/tests/examples_tests.cpp 3f56b30d8d5e2c7257f0499dc2f5ea61a7348633 src/tests/low_level_scheduler_libprocess_test.sh PRE-CREATION src/tests/master_tests.cpp 57721b788d0c70f4c6f5cc44d87465f52a70b6c2 src/tests/scheduler_tests.cpp 946fa8245d8ab35e04bad642d69114caf0ccf6a9 Diff: https://reviews.apache.org/r/36189/diff/ Testing --- make check Thanks, Benjamin Hindman
