Re: Review Request 36215: Dummy /call endpoint for master

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36215/#review90602
---

Ship it!


Thanks isabel, I left some comments and cleaned them up for you, since they are 
pretty trivial.

One follow-up request: We should be rejecting GET requests against the /call 
endpoint, yes? I've added a TODO for you.


src/Makefile.am (line 1468)


Let's call this http_api_tests? At least, that will give us a place to 
collect tests specific to the http api, as I imagine that we will want to test 
http events within the same file.



src/master/http.cpp (lines 295 - 301)


How about a TODO here to provide richer help information? As it is, hard to 
tell how this relates to the http api, what the request bodies should contain, 
etc.



src/master/master.hpp (lines 1064 - 1066)


Hm.. not sure this can remain 'const' given it will have to perform 
non-const operations on the master, but sounds ok for now.



src/tests/call_tests.cpp (line 19)


Need this?



src/tests/call_tests.cpp (line 22)


Need this? I think you need gtest.hpp instead.



src/tests/call_tests.cpp (line 26)


Need this?



src/tests/call_tests.cpp (line 31)


Need this?



src/tests/call_tests.cpp (line 56)


I'm guilty of this too, we don't need the extra space between >> anymore :)



src/tests/call_tests.cpp (line 65)


You don't need this line, the next one captures the expectation that it 
will become ready. :)


- Ben Mahler


On July 6, 2015, 6:31 p.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36215/
> ---
> 
> (Updated July 6, 2015, 6:31 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-2860
> https://issues.apache.org/jira/browse/MESOS-2860
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> ---
> 
> Adding a dummy enpoint for Call requests.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am addb63f 
>   src/master/http.cpp 2be613b 
>   src/master/master.hpp fb4d6fa 
>   src/master/master.cpp c5a4875 
>   src/tests/call_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36215/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 36215: Dummy /call endpoint for master

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36215/#review90585
---


Patch looks great!

Reviews applied: [36215]

All tests passed.

- Mesos ReviewBot


On July 6, 2015, 6:31 p.m., Isabel Jimenez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36215/
> ---
> 
> (Updated July 6, 2015, 6:31 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-2860
> https://issues.apache.org/jira/browse/MESOS-2860
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> ---
> 
> Adding a dummy enpoint for Call requests.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am addb63f 
>   src/master/http.cpp 2be613b 
>   src/master/master.hpp fb4d6fa 
>   src/master/master.cpp c5a4875 
>   src/tests/call_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36215/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Review Request 36215: Dummy /call endpoint for master

[Isabel Jimenez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36215/
---

Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and 
Vinod Kone.


Bugs: MESOS-2860
https://issues.apache.org/jira/browse/MESOS-2860


Repository: mesos-incubating


Description
---

Adding a dummy enpoint for Call requests.


Diffs
-

  src/Makefile.am addb63f 
  src/master/http.cpp 2be613b 
  src/master/master.hpp fb4d6fa 
  src/master/master.cpp c5a4875 
  src/tests/call_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36215/diff/


Testing
---

make check


Thanks,

Isabel Jimenez