Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/#review91223 --- Ship it! Ship It! - Benjamin Hindman On July 8, 2015, 8:23 p.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/ --- (Updated July 8, 2015, 8:23 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-incubating Description --- Adding missing Apache licence header Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 519e38c Diff: https://reviews.apache.org/r/36226/diff/ Testing --- Thanks, Isabel Jimenez
Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/#review90883 --- Ship it! Great, looks good to me now. How about other files like e.g. 3rdparty/libprocess/configure.ac? - Till Toenshoff On July 8, 2015, 12:12 a.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/ --- (Updated July 8, 2015, 12:12 a.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-incubating Description --- Adding missing Apache licence header Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 519e38c Diff: https://reviews.apache.org/r/36226/diff/ Testing --- Thanks, Isabel Jimenez
Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/ --- (Updated July 8, 2015, 8:23 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-incubating Description --- Adding missing Apache licence header Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 519e38c Diff: https://reviews.apache.org/r/36226/diff/ Testing --- Thanks, Isabel Jimenez
Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/#review90983 --- Bad patch! Reviews applied: [23784] Failed command: ./support/apply-review.sh -n -r 23784 Error: 2015-07-08 20:20:09 URL:https://reviews.apache.org/r/23784/diff/raw/ [30874/30874] - 23784.patch [1] Successfully applied: Missing Apache headers for stout Adding missing Apache licence headers on .cpp, .hpp and Makefiles Review: https://reviews.apache.org/r/23784 Checking 28 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo Total errors found: 0 ERROR: Commit spanning multiple projects. Please use separate commits for mesos, libprocess and stout. Paths grouped by project: mesos: support/check-apache-header.sh stout: 3rdparty/libprocess/3rdparty/stout/Makefile.am 3rdparty/libprocess/3rdparty/stout/configure.ac 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 3rdparty/libprocess/3rdparty/stout/tests/bits_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/mac_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/main.cpp 3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp Failed to commit patch - Mesos ReviewBot On July 8, 2015, 6:56 p.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/ --- (Updated July 8, 2015, 6:56 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-incubating Description --- Adding missing Apache licence header Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 519e38c Diff: https://reviews.apache.org/r/36226/diff/ Testing --- Thanks, Isabel Jimenez
Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/#review91022 --- Patch looks great! Reviews applied: [36226] All tests passed. - Mesos ReviewBot On July 8, 2015, 8:23 p.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/ --- (Updated July 8, 2015, 8:23 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-incubating Description --- Adding missing Apache licence header Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 519e38c Diff: https://reviews.apache.org/r/36226/diff/ Testing --- Thanks, Isabel Jimenez
Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/ --- (Updated July 8, 2015, 6:50 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-incubating Description --- Adding missing Apache licence header Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 519e38c Diff: https://reviews.apache.org/r/36226/diff/ Testing --- Thanks, Isabel Jimenez
Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty
On July 8, 2015, 12:13 p.m., Till Toenshoff wrote: Great, looks good to me now. How about other files like e.g. 3rdparty/libprocess/configure.ac? Just added to review 23783, thanks! - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/#review90883 --- On July 8, 2015, 12:12 a.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/ --- (Updated July 8, 2015, 12:12 a.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-incubating Description --- Adding missing Apache licence header Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 519e38c Diff: https://reviews.apache.org/r/36226/diff/ Testing --- Thanks, Isabel Jimenez
Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/ --- (Updated July 8, 2015, 6:51 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-incubating Description --- Adding missing Apache licence header Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 519e38c Diff: https://reviews.apache.org/r/36226/diff/ Testing --- Thanks, Isabel Jimenez
Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/#review90832 --- 3rdparty/libprocess/3rdparty/Makefile.am (lines 1 - 7) https://reviews.apache.org/r/36226/#comment143980 This should be the “Apache License Version 2.0” header instead which applies to libprocess and stout, no? (see docs/mesos-c++-styleguide.md at File Headers). - Till Toenshoff On July 6, 2015, 10:17 p.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/ --- (Updated July 6, 2015, 10:17 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-incubating Description --- Adding missing Apache licence header Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 519e38c Diff: https://reviews.apache.org/r/36226/diff/ Testing --- Thanks, Isabel Jimenez
Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty
On July 7, 2015, 11:43 p.m., Till Toenshoff wrote: 3rdparty/libprocess/3rdparty/Makefile.am, lines 1-7 https://reviews.apache.org/r/36226/diff/1/?file=1000612#file1000612line1 This should be the “Apache License Version 2.0” header instead which applies to libprocess and stout, no? (see docs/mesos-c++-styleguide.md at File Headers). Yes, Till, used the wrong script for this one. My bad. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/#review90832 --- On July 8, 2015, 12:12 a.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/ --- (Updated July 8, 2015, 12:12 a.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-incubating Description --- Adding missing Apache licence header Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 519e38c Diff: https://reviews.apache.org/r/36226/diff/ Testing --- Thanks, Isabel Jimenez
Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/ --- (Updated July 8, 2015, 12:12 a.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-incubating Description --- Adding missing Apache licence header Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am 519e38c Diff: https://reviews.apache.org/r/36226/diff/ Testing --- Thanks, Isabel Jimenez
Review Request 36226: Missing Apache headers for libprocess 3rdparty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-incubating Description --- Adding missing Apache licence header Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 519e38c Diff: https://reviews.apache.org/r/36226/diff/ Testing --- Thanks, Isabel Jimenez
Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/#review90621 --- Patch looks great! Reviews applied: [36226] All tests passed. - Mesos ReviewBot On July 6, 2015, 10:17 p.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/ --- (Updated July 6, 2015, 10:17 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-incubating Description --- Adding missing Apache licence header Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 519e38c Diff: https://reviews.apache.org/r/36226/diff/ Testing --- Thanks, Isabel Jimenez
