Re: Review Request 36461: Added FutureMessageType, DropMessagesType and ExpectNoFutureMessagesType.

2015-07-16 Thread Vinod Kone
On July 15, 2015, 5:29 p.m., Ben Mahler wrote: It looks like this could benefit from a bit of documentation that mentions the protobuf [union technique](https://developers.google.com/protocol-buffers/docs/techniques#union). added a comment on top of the matcher. On July 15, 2015,

Re: Review Request 36461: Added FutureMessageType, DropMessagesType and ExpectNoFutureMessagesType.

2015-07-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36461/ --- (Updated July 17, 2015, 12:48 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 36461: Added FutureMessageType, DropMessagesType and ExpectNoFutureMessagesType.

2015-07-16 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36461/#review92006 --- Ship it! Ship It! - Ben Mahler On July 17, 2015, 12:48 a.m.,

Re: Review Request 36461: Added FutureMessageType, DropMessagesType and ExpectNoFutureMessagesType.

2015-07-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36461/#review91757 --- It looks like this could benefit from a bit of documentation that