Re: Review Request 36510: Update .gitignore with intermediate build artifacts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36510/#review91753 --- Patch looks great! Reviews applied: [36510] All tests passed. - Mesos ReviewBot On July 15, 2015, 4:11 p.m., James Peach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36510/ > --- > > (Updated July 15, 2015, 4:11 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-3054 > https://issues.apache.org/jira/browse/MESOS-3054 > > > Repository: mesos > > > Description > --- > > Update .gitignore with intermediate build artifacts. > > > Diffs > - > > .gitignore-template 934cad71a370d5c64d9a0994f775f39db74f5851 > > Diff: https://reviews.apache.org/r/36510/diff/ > > > Testing > --- > > In a dirty build tree, run ```git status``` and note the reduced clutter. > > > Thanks, > > James Peach > >
Re: Review Request 36510: Update .gitignore with intermediate build artifacts.
> On July 15, 2015, 5:04 p.m., Vinod Kone wrote: > > im assuming you are not building inside "build" directory? Yup. I just found out today that the ```build``` directory was conventional :) - James --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36510/#review91751 --- On July 15, 2015, 4:11 p.m., James Peach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36510/ > --- > > (Updated July 15, 2015, 4:11 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-3054 > https://issues.apache.org/jira/browse/MESOS-3054 > > > Repository: mesos > > > Description > --- > > Update .gitignore with intermediate build artifacts. > > > Diffs > - > > .gitignore-template 934cad71a370d5c64d9a0994f775f39db74f5851 > > Diff: https://reviews.apache.org/r/36510/diff/ > > > Testing > --- > > In a dirty build tree, run ```git status``` and note the reduced clutter. > > > Thanks, > > James Peach > >
Re: Review Request 36510: Update .gitignore with intermediate build artifacts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36510/#review91751 --- Ship it! im assuming you are not building inside "build" directory? - Vinod Kone On July 15, 2015, 4:11 p.m., James Peach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36510/ > --- > > (Updated July 15, 2015, 4:11 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-3054 > https://issues.apache.org/jira/browse/MESOS-3054 > > > Repository: mesos > > > Description > --- > > Update .gitignore with intermediate build artifacts. > > > Diffs > - > > .gitignore-template 934cad71a370d5c64d9a0994f775f39db74f5851 > > Diff: https://reviews.apache.org/r/36510/diff/ > > > Testing > --- > > In a dirty build tree, run ```git status``` and note the reduced clutter. > > > Thanks, > > James Peach > >
Review Request 36510: Update .gitignore with intermediate build artifacts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36510/ --- Review request for mesos and Benjamin Hindman. Bugs: MESOS-3054 https://issues.apache.org/jira/browse/MESOS-3054 Repository: mesos Description --- Update .gitignore with intermediate build artifacts. Diffs - .gitignore-template 934cad71a370d5c64d9a0994f775f39db74f5851 Diff: https://reviews.apache.org/r/36510/diff/ Testing --- In a dirty build tree, run ```git status``` and note the reduced clutter. Thanks, James Peach
