Re: Review Request 36733: Moved framework struct in master to end of file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36733/#review93186 --- Ship it! Ship It! - Ben Mahler On July 25, 2015, 2:11 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36733/ > --- > > (Updated July 25, 2015, 2:11 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos > > > Description > --- > > Moved framework struct to end of file since the framework struct needs to > know about the implementation of master for invoking templated send(...). > Needed for r36318. > > > Diffs > - > > src/master/master.hpp 827d0d599912b2936beb9615610f627f6c9a2d43 > > Diff: https://reviews.apache.org/r/36733/diff/ > > > Testing > --- > > make check > > > Thanks, > > Anand Mazumdar > >
Re: Review Request 36733: Moved framework struct in master to end of file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36733/ --- (Updated July 25, 2015, 2:11 p.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Changes --- missing ";" to satisfy review bot. *Sigh, my bad* Repository: mesos Description --- Moved framework struct to end of file since the framework struct needs to know about the implementation of master for invoking templated send(...). Needed for r36318. Diffs (updated) - src/master/master.hpp 827d0d599912b2936beb9615610f627f6c9a2d43 Diff: https://reviews.apache.org/r/36733/diff/ Testing --- make check Thanks, Anand Mazumdar
Re: Review Request 36733: Moved framework struct in master to end of file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36733/ --- (Updated July 25, 2015, 7:20 a.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Changes --- rebased to make r36720 happy. Repository: mesos Description --- Moved framework struct to end of file since the framework struct needs to know about the implementation of master for invoking templated send(...). Needed for r36318. Diffs (updated) - src/master/master.hpp 827d0d599912b2936beb9615610f627f6c9a2d43 Diff: https://reviews.apache.org/r/36733/diff/ Testing --- make check Thanks, Anand Mazumdar
Re: Review Request 36733: Moved framework struct in master to end of file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36733/ --- (Updated July 24, 2015, 8:12 p.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Changes --- rebased + added a new line I had removed erroneously. Repository: mesos Description --- Moved framework struct to end of file since the framework struct needs to know about the implementation of master for invoking templated send(...). Needed for r36318. Diffs (updated) - src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec Diff: https://reviews.apache.org/r/36733/diff/ Testing --- make check Thanks, Anand Mazumdar
Re: Review Request 36733: Moved framework struct in master to end of file
> On July 23, 2015, 7:25 p.m., Joseph Wu wrote:
> > Is there anything preventing you from using forward declarations? Or just
> > implementing the templated send function after the Master has been defined?
> >
> > i.e.
> > ```
> > struct Framework {
> > ...
> > template
> > void send(const Message& message);
> > ...
> > }
> >
> > class Master { ... }
> >
> > template
> > void Framework::send(const Message& message) {
> > ...
> > }
> > ```
For some reason , the forward declaration did not work for me and the compiler
barfed out. ( might have to do with this class being a friend of master to
invoke the protected send(...) method ). I did not dig into it much.
- Anand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36733/#review92792
---
On July 23, 2015, 5:26 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36733/
> ---
>
> (Updated July 23, 2015, 5:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Moved framework struct to end of file since the framework struct needs to
> know about the implementation of master for invoking templated send(...).
> Needed for r36318.
>
>
> Diffs
> -
>
> src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec
>
> Diff: https://reviews.apache.org/r/36733/diff/
>
>
> Testing
> ---
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 36733: Moved framework struct in master to end of file
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36733/#review92792
---
Is there anything preventing you from using forward declarations? Or just
implementing the templated send function after the Master has been defined?
i.e.
```
struct Framework {
...
template
void send(const Message& message);
...
}
class Master { ... }
template
void Framework::send(const Message& message) {
...
}
```
- Joseph Wu
On July 23, 2015, 10:26 a.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36733/
> ---
>
> (Updated July 23, 2015, 10:26 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Moved framework struct to end of file since the framework struct needs to
> know about the implementation of master for invoking templated send(...).
> Needed for r36318.
>
>
> Diffs
> -
>
> src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec
>
> Diff: https://reviews.apache.org/r/36733/diff/
>
>
> Testing
> ---
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Review Request 36733: Moved framework struct in master to end of file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36733/ --- Review request for mesos, Benjamin Hindman and Ben Mahler. Repository: mesos Description --- Moved framework struct to end of file since the framework struct needs to know about the implementation of master for invoking templated send(...). Needed for r36318. Diffs - src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec Diff: https://reviews.apache.org/r/36733/diff/ Testing --- make check Thanks, Anand Mazumdar
