Re: Review Request 36810: Don't check protobuf jar in libprocess.

2015-08-04 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36810/#review94175 --- Ship it! Seems reasonable to me. I haven't run a build personally t

Re: Review Request 36810: Don't check protobuf jar in libprocess.

2015-07-30 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36810/#review93565 --- Ship it! LGTM. Any build experts want to take a look? @tstclair, @c

Re: Review Request 36810: Don't check protobuf jar in libprocess.

2015-07-28 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36810/ --- (Updated July 29, 2015, 2:43 a.m.) Review request for mesos, Adam B and Niklas

Re: Review Request 36810: Don't check protobuf jar in libprocess.

2015-07-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36810/#review93317 --- Patch looks great! Reviews applied: [36810] All tests passed. - M

Re: Review Request 36810: Don't check protobuf jar in libprocess.

2015-07-27 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36810/#review93239 --- Did you test this with java enabled as well? What about without `--

Re: Review Request 36810: Don't check protobuf jar in libprocess.

2015-07-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36810/ --- (Updated July 25, 2015, 8:21 a.m.) Review request for mesos and Niklas Nielsen.

Review Request 36810: Don't check protobuf jar in libprocess.

2015-07-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36810/ --- Review request for mesos and Niklas Nielsen. Bugs: MESOS-2480 https://issue