Re: Review Request 36979: Updating all references to os::shell

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36979/#review94892 --- Patch looks great! Reviews applied: [36978, 36979] All tests passe

Re: Review Request 36979: Updating all references to os::shell

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36979/ --- (Updated Aug. 11, 2015, 7:40 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36979: Updating all references to os::shell

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36979/ --- (Updated Aug. 11, 2015, 7:37 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36979: Updating all references to os::shell

> On Aug. 11, 2015, 6 a.m., Benjamin Hindman wrote: > > src/hdfs/hdfs.hpp, lines 123-127 > > > > > > Wait, how was `|| true` the existing semantics? We are definitely > > capturing stderr into stdout, but I don't se

Re: Review Request 36979: Updating all references to os::shell

> On Aug. 11, 2015, 6 a.m., Benjamin Hindman wrote: > > src/tests/containerizer/port_mapping_tests.cpp, line 975 > > > > > > Minor nit, how about here and below: > > > > ASSERT_FALSE(strings::contains(invali

Re: Review Request 36979: Updating all references to os::shell

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36979/#review94880 --- Ship it! src/hdfs/hdfs.hpp (lines 69 - 88)

Re: Review Request 36979: Updating all references to os::shell

> On Aug. 6, 2015, 10:26 p.m., Guangya Liu wrote: > > src/hdfs/hdfs.hpp, line 110 > > > > > > Why not use the following? > > > > return !out.get().empty(); Actually, that was exactly what I originally type

Re: Review Request 36979: Updating all references to os::shell

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36979/#review94453 --- src/hdfs/hdfs.hpp (line 110)

Re: Review Request 36979: Updating all references to os::shell

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36979/#review94452 --- Patch looks great! Reviews applied: [36978, 36979] All tests passe

Re: Review Request 36979: Updating all references to os::shell

> On Aug. 5, 2015, 4:16 a.m., Artem Harutyunyan wrote: > > src/tests/containerizer/port_mapping_tests.cpp, line 986 > > > > > > ditto. > > + extra newline. > > Marco Massenzio wrote: > Having looked at both

Re: Review Request 36979: Updating all references to os::shell

> On Aug. 5, 2015, 4:16 a.m., Artem Harutyunyan wrote: > > src/tests/containerizer/port_mapping_tests.cpp, line 986 > > > > > > ditto. > > + extra newline. > > Marco Massenzio wrote: > Having looked at both

Re: Review Request 36979: Updating all references to os::shell

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36979/ --- (Updated Aug. 6, 2015, 6:24 p.m.) Review request for mesos, Benjamin Hindman an

Re: Review Request 36979: Updating all references to os::shell

> On Aug. 4, 2015, 9:16 p.m., Artem Harutyunyan wrote: > > src/tests/containerizer/port_mapping_tests.cpp, line 986 > > > > > > ditto. > > + extra newline. > > Marco Massenzio wrote: > Having looked at both

Re: Review Request 36979: Updating all references to os::shell

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36979/#review94286 --- Patch looks great! Reviews applied: [36978, 36979] All tests passe

Re: Review Request 36979: Updating all references to os::shell

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36979/ --- (Updated Aug. 5, 2015, 5:10 p.m.) Review request for mesos, Benjamin Hindman an

Re: Review Request 36979: Updating all references to os::shell

> On Aug. 5, 2015, 4:16 a.m., Artem Harutyunyan wrote: > > src/tests/containerizer/isolator_tests.cpp, line 1269 > > > > > > You are right that the awk did not actually seem to accomplish anything > > meaningful he

Re: Review Request 36979: Updating all references to os::shell

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36979/#review94177 --- src/slave/containerizer/isolators/network/port_mapping.cpp (line 15

Re: Review Request 36979: Updating all references to os::shell

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36979/#review93709 --- Patch looks great! Reviews applied: [36978, 36979] All tests passe

Review Request 36979: Updating all references to os::shell

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36979/ --- Review request for mesos. Bugs: MESOS-3142 https://issues.apache.org/jira/b