Re: Review Request 37002: Introduced ACL protobuf definitions for dynamic reservation.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37002/#review98338
---



include/mesos/mesos.proto (line 1120)


Yes, here should be reserve resource.

Another is that the ACL is now moved to v1 API, you may need  a rebase here.


- Guangya Liu


On 八月 5, 2015, 9:57 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37002/
> ---
> 
> (Updated 八月 5, 2015, 9:57 a.m.)
> 
> 
> Review request for mesos, Adam B and Jie Yu.
> 
> 
> Bugs: MESOS-3062
> https://issues.apache.org/jira/browse/MESOS-3062
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba 
> 
> Diff: https://reviews.apache.org/r/37002/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 37002: Introduced ACL protobuf definitions for dynamic reservation.

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37002/#review95010
---

Ship it!


LGTM module comments.
FYI - Adam is out for the next several weeks, but I think @Jie can shepherd 
this?


include/mesos/mesos.proto (line 1120)
https://reviews.apache.org/r/37002/#comment149765

is this comment here right? or a copypaste fail? :)



include/mesos/mesos.proto (lines 1167 - 1168)
https://reviews.apache.org/r/37002/#comment149766

for repeated fields is usually good practice to have them ending in a 
plural (`reserves`?)
In this case, maybe `reservations`? `reserved_resources`?


- Marco Massenzio


On Aug. 5, 2015, 9:57 a.m., Michael Park wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37002/
 ---
 
 (Updated Aug. 5, 2015, 9:57 a.m.)
 
 
 Review request for mesos, Adam B and Jie Yu.
 
 
 Bugs: MESOS-3062
 https://issues.apache.org/jira/browse/MESOS-3062
 
 
 Repository: mesos
 
 
 Description
 ---
 
 See summary.
 
 
 Diffs
 -
 
   include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba 
 
 Diff: https://reviews.apache.org/r/37002/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Michael Park