Re: Review Request 37046: Merged registerFramework() and reregisterFramework().

2015-08-04 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37046/#review94028
---


Patch looks great!

Reviews applied: [37046]

All tests passed.

- Mesos ReviewBot


On Aug. 3, 2015, 9:47 p.m., Vinod Kone wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37046/
 ---
 
 (Updated Aug. 3, 2015, 9:47 p.m.)
 
 
 Review request for mesos, Anand Mazumdar and Ben Mahler.
 
 
 Bugs: MESOS-3182
 https://issues.apache.org/jira/browse/MESOS-3182
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Merged registerFramework() and reregisterFramework() (and their corresponding 
 continuations) into subscribe() (and _subscribe()).
 
 
 Diffs
 -
 
   src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
   src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 
 
 Diff: https://reviews.apache.org/r/37046/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Vinod Kone
 




Re: Review Request 37046: Merged registerFramework() and reregisterFramework().

2015-08-03 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37046/
---

(Updated Aug. 3, 2015, 9:47 p.m.)


Review request for mesos, Anand Mazumdar and Ben Mahler.


Changes
---

benm's. NNFR.


Bugs: MESOS-3182
https://issues.apache.org/jira/browse/MESOS-3182


Repository: mesos


Description
---

Merged registerFramework() and reregisterFramework() (and their corresponding 
continuations) into subscribe() (and _subscribe()).


Diffs (updated)
-

  src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
  src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 

Diff: https://reviews.apache.org/r/37046/diff/


Testing
---

make check


Thanks,

Vinod Kone



Review Request 37046: Merged registerFramework() and reregisterFramework().

2015-08-03 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37046/
---

Review request for mesos, Anand Mazumdar and Ben Mahler.


Bugs: MESOS-3182
https://issues.apache.org/jira/browse/MESOS-3182


Repository: mesos


Description
---

Merged registerFramework() and reregisterFramework() (and their corresponding 
continuations) into subscribe() (and _subscribe()).


Diffs
-

  src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc 
  src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 

Diff: https://reviews.apache.org/r/37046/diff/


Testing
---

make check


Thanks,

Vinod Kone