Re: Review Request 37054: Moved ContainerInfo::Image definition to the top level.

2015-08-03 Thread Timothy Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37054/#review93997
---

Ship it!


Ship It!

- Timothy Chen


On Aug. 3, 2015, 11:09 p.m., Jie Yu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37054/
 ---
 
 (Updated Aug. 3, 2015, 11:09 p.m.)
 
 
 Review request for mesos, Benjamin Hindman, Timothy Chen, and Vinod Kone.
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Moved ContainerInfo::Image definition to the top level.
 
 Motivation is captured in this doc:
 https://docs.google.com/document/d/1n2emC2ruTMur5nURvLgGYJxuP-tgBwgLDrmg_17QSmA/edit#
 
 
 Diffs
 -
 
   include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba 
   src/slave/containerizer/mesos/containerizer.hpp 
 8851d30af56b4f9fb95450ac1f42ab550e3df9ff 
   src/slave/containerizer/mesos/containerizer.cpp 
 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1 
   src/slave/containerizer/provisioner.hpp 
 cb4d511e8189b65df9b9803f23812dd98edc44ac 
   src/slave/containerizer/provisioner.cpp 
 df52e36b23ad3cd28f50e96865d0b163cc245cb2 
   src/tests/containerizer/mesos_containerizer_tests.cpp 
 213fa4b0b9c50eba941ef6b52497eb32d539 
 
 Diff: https://reviews.apache.org/r/37054/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Jie Yu
 




Re: Review Request 37054: Moved ContainerInfo::Image definition to the top level.

2015-08-03 Thread Timothy Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37054/#review93996
---



include/mesos/mesos.proto (line 1194)
https://reviews.apache.org/r/37054/#comment148490

I think it's worth mentioninig, specifically provided for provisioners and 
the Mesos containerizer.


- Timothy Chen


On Aug. 3, 2015, 11:09 p.m., Jie Yu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37054/
 ---
 
 (Updated Aug. 3, 2015, 11:09 p.m.)
 
 
 Review request for mesos, Benjamin Hindman, Timothy Chen, and Vinod Kone.
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Moved ContainerInfo::Image definition to the top level.
 
 Motivation is captured in this doc:
 https://docs.google.com/document/d/1n2emC2ruTMur5nURvLgGYJxuP-tgBwgLDrmg_17QSmA/edit#
 
 
 Diffs
 -
 
   include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba 
   src/slave/containerizer/mesos/containerizer.hpp 
 8851d30af56b4f9fb95450ac1f42ab550e3df9ff 
   src/slave/containerizer/mesos/containerizer.cpp 
 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1 
   src/slave/containerizer/provisioner.hpp 
 cb4d511e8189b65df9b9803f23812dd98edc44ac 
   src/slave/containerizer/provisioner.cpp 
 df52e36b23ad3cd28f50e96865d0b163cc245cb2 
   src/tests/containerizer/mesos_containerizer_tests.cpp 
 213fa4b0b9c50eba941ef6b52497eb32d539 
 
 Diff: https://reviews.apache.org/r/37054/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Jie Yu