Re: Review Request 37162: Add GTEST_LANG_CXX11 to configure.ac when compile.

2015-08-07 Thread Michael Park

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37162/#review94512
---

Ship it!


Ship It!

- Michael Park


On Aug. 7, 2015, 3:30 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37162/
> ---
> 
> (Updated Aug. 7, 2015, 3:30 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3141
> https://issues.apache.org/jira/browse/MESOS-3141
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   LICENSE 8757c208f91e9fa000574489bdb7432a0777d923 
>   configure.ac 230e90d3165618e8cf50e8d34bdfc41119ab24a3 
> 
> Diff: https://reviews.apache.org/r/37162/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 37162: Add GTEST_LANG_CXX11 to configure.ac when compile.

2015-08-07 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37162/#review94506
---


Patch looks great!

Reviews applied: [37162]

All tests passed.

- Mesos ReviewBot


On Aug. 7, 2015, 3:30 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37162/
> ---
> 
> (Updated Aug. 7, 2015, 3:30 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3141
> https://issues.apache.org/jira/browse/MESOS-3141
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   LICENSE 8757c208f91e9fa000574489bdb7432a0777d923 
>   configure.ac 230e90d3165618e8cf50e8d34bdfc41119ab24a3 
> 
> Diff: https://reviews.apache.org/r/37162/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 37162: Add GTEST_LANG_CXX11 to configure.ac when compile.

2015-08-06 Thread haosdent huang


> On Aug. 7, 2015, 12:01 a.m., Michael Park wrote:
> > We should also update the `LICENSE` file to reflect this update.
> > 
> > ```
> >  ==
> > -For gmock-1.6.0 (3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz):
> > +For gmock-1.7.0 (3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz):
> >  ==
> > ```

Thank you, I updated it now.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37162/#review94467
---


On Aug. 7, 2015, 3:30 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37162/
> ---
> 
> (Updated Aug. 7, 2015, 3:30 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3141
> https://issues.apache.org/jira/browse/MESOS-3141
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   LICENSE 8757c208f91e9fa000574489bdb7432a0777d923 
>   configure.ac 230e90d3165618e8cf50e8d34bdfc41119ab24a3 
> 
> Diff: https://reviews.apache.org/r/37162/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 37162: Add GTEST_LANG_CXX11 to configure.ac when compile.

2015-08-06 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37162/
---

(Updated Aug. 7, 2015, 3:30 a.m.)


Review request for mesos and Michael Park.


Bugs: MESOS-3141
https://issues.apache.org/jira/browse/MESOS-3141


Repository: mesos


Description
---

See summary.


Diffs
-

  LICENSE 8757c208f91e9fa000574489bdb7432a0777d923 
  configure.ac 230e90d3165618e8cf50e8d34bdfc41119ab24a3 

Diff: https://reviews.apache.org/r/37162/diff/


Testing
---


Thanks,

haosdent huang



Re: Review Request 37162: Add GTEST_LANG_CXX11 to configure.ac when compile.

2015-08-06 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37162/
---

(Updated Aug. 7, 2015, 3:30 a.m.)


Review request for mesos and Michael Park.


Bugs: MESOS-3141
https://issues.apache.org/jira/browse/MESOS-3141


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  LICENSE 8757c208f91e9fa000574489bdb7432a0777d923 
  configure.ac 230e90d3165618e8cf50e8d34bdfc41119ab24a3 

Diff: https://reviews.apache.org/r/37162/diff/


Testing
---


Thanks,

haosdent huang



Re: Review Request 37162: Add GTEST_LANG_CXX11 to configure.ac when compile.

2015-08-06 Thread Michael Park

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37162/#review94467
---


We should also update the `LICENSE` file to reflect this update.

```
 ==
-For gmock-1.6.0 (3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz):
+For gmock-1.7.0 (3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz):
 ==
```

- Michael Park


On Aug. 6, 2015, 5:12 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37162/
> ---
> 
> (Updated Aug. 6, 2015, 5:12 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3141
> https://issues.apache.org/jira/browse/MESOS-3141
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   configure.ac 230e90d3165618e8cf50e8d34bdfc41119ab24a3 
> 
> Diff: https://reviews.apache.org/r/37162/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 37162: Add GTEST_LANG_CXX11 to configure.ac when compile.

2015-08-05 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37162/#review94362
---


Patch looks great!

Reviews applied: [37162]

All tests passed.

- Mesos ReviewBot


On Aug. 6, 2015, 5:12 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37162/
> ---
> 
> (Updated Aug. 6, 2015, 5:12 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3141
> https://issues.apache.org/jira/browse/MESOS-3141
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   configure.ac 230e90d3165618e8cf50e8d34bdfc41119ab24a3 
> 
> Diff: https://reviews.apache.org/r/37162/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 37162: Add GTEST_LANG_CXX11 to configure.ac when compile.

2015-08-05 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37162/
---

(Updated Aug. 6, 2015, 5:12 a.m.)


Review request for mesos and Michael Park.


Bugs: MESOS-3141
https://issues.apache.org/jira/browse/MESOS-3141


Repository: mesos


Description (updated)
---

See summary.


Diffs
-

  configure.ac 230e90d3165618e8cf50e8d34bdfc41119ab24a3 

Diff: https://reviews.apache.org/r/37162/diff/


Testing
---


Thanks,

haosdent huang



Review Request 37162: Add GTEST_LANG_CXX11 to configure.ac when compile.

2015-08-05 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37162/
---

Review request for mesos.


Repository: mesos


Description
---

Add GTEST_LANG_CXX11 to configure.ac when compile.


Diffs
-

  configure.ac 230e90d3165618e8cf50e8d34bdfc41119ab24a3 

Diff: https://reviews.apache.org/r/37162/diff/


Testing
---


Thanks,

haosdent huang



Re: Review Request 37162: Add GTEST_LANG_CXX11 to configure.ac when compile.

2015-08-05 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37162/
---

(Updated Aug. 6, 2015, 4:23 a.m.)


Review request for mesos.


Bugs: MESOS-3141
https://issues.apache.org/jira/browse/MESOS-3141


Repository: mesos


Description
---

Add GTEST_LANG_CXX11 to configure.ac when compile.


Diffs
-

  configure.ac 230e90d3165618e8cf50e8d34bdfc41119ab24a3 

Diff: https://reviews.apache.org/r/37162/diff/


Testing
---


Thanks,

haosdent huang