Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2016-01-13 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review114192 --- ping @mcypark :). - Klaus Ma On Dec. 13, 2015, 11:28 p.m.,

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-12-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review110178 --- Patch looks great! Reviews applied: [37168] Passed command:

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-12-13 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated Dec. 13, 2015, 11:28 p.m.) Review request for mesos and Michael Park.

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-11-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review105661 --- Patch looks great! Reviews applied: [37168] All tests passed. -

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-11-09 Thread Klaus Ma
> On Oct. 6, 2015, 7:12 a.m., Michael Park wrote: > > src/examples/dynamic_reservation_framework.cpp, lines 120-123 > > > > > > `reserveResources` returns an error when there are not enough resources > > available.

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-11-09 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated Nov. 9, 2015, 4:10 p.m.) Review request for mesos and Michael Park.

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-11-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review105651 --- Patch looks great! Reviews applied: [37168] All tests passed. -

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-11-08 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated Nov. 9, 2015, 1:29 p.m.) Review request for mesos and Michael Park.

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-09-14 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review98818 --- src/Makefile.am (line 1463)

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-09-14 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated Sept. 14, 2015, 1:48 p.m.) Review request for mesos and Michael Park.

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-09-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review98943 --- Patch looks great! Reviews applied: [37168] All tests passed. -

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-09-12 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review98746 --- Some preliminary comments.

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-09-08 Thread Klaus Ma
Hi Michael, Do you have more comments about this example? On 2015年09月06日 21:28, Klaus Ma wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ On September 6th, 2015, 8:49 a.m. UTC, *Joerg Schad* wrote: src/Makefile.am

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-09-06 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review97885 --- src/Makefile.am (line 1463)

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-09-06 Thread Klaus Ma
> On Sept. 6, 2015, 8:49 a.m., Joerg Schad wrote: > > src/examples/dynamic_reservation_framework.cpp, line 283 > > > > > > s/TASK_DONE/TASKS_DONE > > > > Please correct me if I am wrong: TASK_DONE is a

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-09-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review97882 --- Patch looks great! Reviews applied: [37168] All tests passed. -

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-09-05 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated Sept. 6, 2015, 4:11 a.m.) Review request for mesos and Michael Park.

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-09-04 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated Sept. 5, 2015, 3:14 a.m.) Review request for mesos and Michael Park.

Re: Review Request 37168: MESOS-3063

2015-09-02 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review97423 --- As this is an example framework (which will be used by people to

Re: Review Request 37168: MESOS-3063

2015-09-02 Thread Klaus Ma
> On Sept. 2, 2015, 7:30 a.m., Joerg Schad wrote: > > As this is an example framework (which will be used by people to start > > their own framework), would it make sense to add some more comments > > explaining especially the relevant bits here? Agree, let me add more comments for the detail

Re: Review Request 37168: MESOS-3063

2015-08-26 Thread Klaus Ma
The tests failed because script.cpp can not find test script which has been updated; I'm working to check it, although the root cause is un-clear now. [ RUN ] ExamplesTest.DynamicReservationFramework ../../src/tests/script.cpp:66: Failure Failed Failed to locate script: No such file or

Re: Review Request 37168: MESOS-3063

2015-08-26 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated 八月 27, 2015, 3:33 a.m.) Review request for mesos. Bugs: MESOS-3063

Re: Review Request 37168: MESOS-3063

2015-08-13 Thread Klaus Ma
On 八月 13, 2015, 2:56 a.m., haosdent huang wrote: src/examples/dynamic_reservation_framework.cpp, line 343 https://reviews.apache.org/r/37168/diff/1/?file=1033410#file1033410line343 Does we need add ``` logging::initialize(argv[0], flags, true); ``` here?

Re: Review Request 37168: MESOS-3063

2015-08-12 Thread haosdent huang
On Aug. 13, 2015, 2:56 a.m., haosdent huang wrote: Hi, @klaus1982 Thanks you for you nice example. I think you need add your Shepherd as reviewer in this patch. - haosdent --- This is an automatically generated e-mail. To reply,

Re: Review Request 37168: MESOS-3063

2015-08-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review95227 --- src/examples/dynamic_reservation_framework.cpp (line 267)

Review Request 37168: MESOS-3063

2015-08-06 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- Review request for mesos. Bugs: MESOS-3063

Re: Review Request 37168: MESOS-3063

2015-08-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review94390 --- Patch looks great! Reviews applied: [37168] All tests passed. -