Re: Review Request 37304: Add authorization for http based schedulers

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37304/
---

(Updated Aug. 11, 2015, 7:48 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

removing "depends on" -- @vinodkone


Repository: mesos


Description
---

See summary


Diffs
-

  src/master/master.hpp 10cc100b1cf10aa7a8a9979a2562a9c5a9e55bd6 
  src/master/master.cpp 08dd34d9d18f547c6e8d04caf9e39a2b3ffc5f63 

Diff: https://reviews.apache.org/r/37304/diff/


Testing
---

make check + would add tests in separate patch


Thanks,

Anand Mazumdar

Re: Review Request 37304: Add authorization for http based schedulers

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37304/#review94968
---

Ship it!


I think this can be pulled out of this chain to commit it sooner. i can make 
the changes and commit it for you, if you like.


src/master/master.cpp (line 1828)


indentation. put HttpConnection on the next line?



src/master/master.cpp (line 2094)


ditto. indentation.


- Vinod Kone


On Aug. 11, 2015, 3:24 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37304/
> ---
> 
> (Updated Aug. 11, 2015, 3:24 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 10cc100b1cf10aa7a8a9979a2562a9c5a9e55bd6 
>   src/master/master.cpp 08dd34d9d18f547c6e8d04caf9e39a2b3ffc5f63 
> 
> Diff: https://reviews.apache.org/r/37304/diff/
> 
> 
> Testing
> ---
> 
> make check + would add tests in separate patch
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 37304: Add authorization for http based schedulers

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37304/
---

(Updated Aug. 11, 2015, 3:24 a.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Review comments


Repository: mesos


Description
---

See summary


Diffs (updated)
-

  src/master/master.hpp 10cc100b1cf10aa7a8a9979a2562a9c5a9e55bd6 
  src/master/master.cpp 08dd34d9d18f547c6e8d04caf9e39a2b3ffc5f63 

Diff: https://reviews.apache.org/r/37304/diff/


Testing
---

make check + would add tests in separate patch


Thanks,

Anand Mazumdar

Re: Review Request 37304: Add authorization for http based schedulers

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37304/#review94819
---

Ship it!



src/master/master.cpp (line 1828)


Is it possible to s/f/_subscribe/ or would the compiler barf?



src/master/master.cpp (line 1863)


add a colon before the error message.



src/master/master.cpp (line 2094)


ditto. can we rename 'f' to '_subscribe' ?


- Vinod Kone


On Aug. 10, 2015, 5 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37304/
> ---
> 
> (Updated Aug. 10, 2015, 5 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 10cc100b1cf10aa7a8a9979a2562a9c5a9e55bd6 
>   src/master/master.cpp 08dd34d9d18f547c6e8d04caf9e39a2b3ffc5f63 
> 
> Diff: https://reviews.apache.org/r/37304/diff/
> 
> 
> Testing
> ---
> 
> make check + would add tests in separate patch
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Review Request 37304: Add authorization for http based schedulers

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37304/
---

Review request for mesos, Ben Mahler and Vinod Kone.


Repository: mesos


Description
---

See summary


Diffs
-

  src/master/master.hpp 10cc100b1cf10aa7a8a9979a2562a9c5a9e55bd6 
  src/master/master.cpp 08dd34d9d18f547c6e8d04caf9e39a2b3ffc5f63 

Diff: https://reviews.apache.org/r/37304/diff/


Testing
---

make check + would add tests in separate patch


Thanks,

Anand Mazumdar