Re: Review Request 37307: Changed Image::AppC::id from required to optional.

2015-08-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37307/#review94939 --- Ship it! Ship It! - Jie Yu On Aug. 10, 2015, 6:31 p.m., Jiang

Review Request 37307: Changed Image::AppC::id from required to optional.

2015-08-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37307/ --- Review request for mesos, Ian Downes, Jie Yu, Timothy Chen, and Vinod Kone.

Re: Review Request 37307: Changed Image::AppC::id from required to optional.

2015-08-10 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37307/#review94792 --- include/mesos/mesos.proto (line 1208)

Re: Review Request 37307: Changed Image::AppC::id from required to optional.

2015-08-10 Thread Jiang Yan Xu
On Aug. 10, 2015, 1:29 p.m., Timothy Chen wrote: include/mesos/mesos.proto, line 1208 https://reviews.apache.org/r/37307/diff/1/?file=1036508#file1036508line1208 Should the user have the ability then to specify either a name or a id? If name is required then I don't see