Re: Review Request 37420: Added note regarding glog and gflags to documentation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37420/#review95245 --- Thanks for taking this on Greg. docs/getting-started.md (line 1) https://reviews.apache.org/r/37420/#comment150101 Whooopsi?! :) docs/getting-started.md (line 174) https://reviews.apache.org/r/37420/#comment150105 The current patch for glog is not related to this very issue - that old patch that I recently resurrected does. Our complete glog patch does other things that are mostly fixing C++11 stuff and standard library issues. So we might want to be a bit more precise here - maybe by even referencing the ticket and the exact patch. What do you think? - Till Toenshoff On Aug. 12, 2015, 10:25 p.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37420/ --- (Updated Aug. 12, 2015, 10:25 p.m.) Review request for mesos, Joris Van Remoortere and Till Toenshoff. Bugs: MESOS-1010 https://issues.apache.org/jira/browse/MESOS-1010 Repository: mesos Description --- Added note regarding glog and gflags to documentation Diffs - docs/getting-started.md 1203ab88fde1c4a72c1bef6e85293f4d9abb2e24 Diff: https://reviews.apache.org/r/37420/diff/ Testing --- Thanks, Greg Mann
Review Request 37420: Added note regarding glog and gflags to documentation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37420/ --- Review request for mesos, Joris Van Remoortere and Till Toenshoff. Bugs: MESOS-1010 https://issues.apache.org/jira/browse/MESOS-1010 Repository: mesos Description --- Added note regarding glog and gflags to documentation Diffs - docs/getting-started.md 1203ab88fde1c4a72c1bef6e85293f4d9abb2e24 Diff: https://reviews.apache.org/r/37420/diff/ Testing --- Thanks, Greg Mann
Re: Review Request 37420: Added note regarding glog and gflags to documentation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37420/#review95217 --- Patch looks great! Reviews applied: [37420] All tests passed. - Mesos ReviewBot On Aug. 12, 2015, 10:25 p.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37420/ --- (Updated Aug. 12, 2015, 10:25 p.m.) Review request for mesos, Joris Van Remoortere and Till Toenshoff. Bugs: MESOS-1010 https://issues.apache.org/jira/browse/MESOS-1010 Repository: mesos Description --- Added note regarding glog and gflags to documentation Diffs - docs/getting-started.md 1203ab88fde1c4a72c1bef6e85293f4d9abb2e24 Diff: https://reviews.apache.org/r/37420/diff/ Testing --- Thanks, Greg Mann
