Re: Review Request 37468: Removed allocation types to mesos::master namespace
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37468/ --- (Updated Oct. 7, 2015, 2:04 a.m.) Review request for mesos. Bugs: MESOS-2516 https://issues.apache.org/jira/browse/MESOS-2516 Repository: mesos Description --- The allocation-related types was moved to mesos::master namespace. MESOS-2516 Diffs - docs/allocation-module.md 4ba5ba8c27cccebf0e5fc5064fdc1d6af05d38f0 include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 src/examples/test_allocator_module.cpp 9679fd9f9a998834bc5329efa07d46a0403ab3f6 src/local/local.hpp 6bb25f16982d7be067b5f1307d5eca7745820e81 src/local/local.cpp 4d98bf23705027f3ba0cbb571289f21b288fe7db src/master/allocator/allocator.cpp 42214048e83cb50bdb669d79fa49401c1716de87 src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659 src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629 src/master/allocator/sorter/drf/sorter.hpp f66ade06c6a5b4bf816839477cec2d18036c7b1a src/master/allocator/sorter/drf/sorter.cpp bfc273493419fe46a4d907f4f7fa282cff71b800 src/master/allocator/sorter/sorter.hpp 536a7ad9a2d661bc8aa352d2e0ae41115b1e8a04 src/master/main.cpp e024a2e4beeb58438accd07e1b87ea239fb1d88b src/master/master.hpp 1e12f650796acafcee83cf9bd0b85f57d359333c src/master/master.cpp c5e6c6f3304060d4c92d52851951f10bc432500e src/tests/cluster.hpp 114583de8c867495a2b7a953e6826708838e5d23 src/tests/fault_tolerance_tests.cpp c63599ad36d883d25a23f5bab1929c4e2dad4960 src/tests/hierarchical_allocator_tests.cpp 9748ca0b3fee25dcec51c64d8ba84dbd4aaf src/tests/master_allocator_tests.cpp 89331965553505f6b7eebf39ad27d943df816a24 src/tests/master_authorization_tests.cpp f3f0cc81ab958e5b9a2bc458f5c38b3e12202514 src/tests/master_tests.cpp a4703afc331244a9e959c48652342f31ef787288 src/tests/mesos.hpp 64987f0cc1632eb8b0c2cccd8446a5324127910c src/tests/mesos.cpp 9bff4a66604a67d9add5a05247548e0162f3cda7 src/tests/partition_tests.cpp b7030adcfb1bfb128040aff20f12461412b5382c src/tests/rate_limiting_tests.cpp f3aeddee00c7bb7905092aa8a760603468063126 src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b src/tests/resource_offers_tests.cpp 882a9ff4d09aace486182828bf43b643b0d0c519 src/tests/scheduler_driver_tests.cpp 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 src/tests/scheduler_tests.cpp 7842f27673cc0fc11864916dda4ca4bbb66d9dbd src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc src/tests/sorter_tests.cpp 0db9a046007c1e89edb2af1e5d63cbc40934e2af Diff: https://reviews.apache.org/r/37468/diff/ Testing --- Thanks, Jose Guilherme Vanz
Re: Review Request 37468: Removed allocation types to mesos::master namespace
On Aug. 14, 2015, 12:21 p.m., Guangya Liu wrote: Code looks good, but pls check what is wrong with the build Solved! There is an issue in the apply-review.sh. The script crashes because my name has é. After I changed my name in the review board the script runs fine - Jose Guilherme --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37468/#review95418 --- On Aug. 14, 2015, 2:01 a.m., Jose Guilherme Vanz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37468/ --- (Updated Aug. 14, 2015, 2:01 a.m.) Review request for mesos. Bugs: MESOS-2516 https://issues.apache.org/jira/browse/MESOS-2516 Repository: mesos Description --- The allocation-related types was moved to mesos::master namespace. MESOS-2516 Diffs - docs/allocation-module.md 4ba5ba8c27cccebf0e5fc5064fdc1d6af05d38f0 include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 src/examples/test_allocator_module.cpp 9679fd9f9a998834bc5329efa07d46a0403ab3f6 src/local/local.hpp 6bb25f16982d7be067b5f1307d5eca7745820e81 src/local/local.cpp 4d98bf23705027f3ba0cbb571289f21b288fe7db src/master/allocator/allocator.cpp 42214048e83cb50bdb669d79fa49401c1716de87 src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659 src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629 src/master/allocator/sorter/drf/sorter.hpp f66ade06c6a5b4bf816839477cec2d18036c7b1a src/master/allocator/sorter/drf/sorter.cpp bfc273493419fe46a4d907f4f7fa282cff71b800 src/master/allocator/sorter/sorter.hpp 536a7ad9a2d661bc8aa352d2e0ae41115b1e8a04 src/master/main.cpp e024a2e4beeb58438accd07e1b87ea239fb1d88b src/master/master.hpp 1e12f650796acafcee83cf9bd0b85f57d359333c src/master/master.cpp c5e6c6f3304060d4c92d52851951f10bc432500e src/tests/cluster.hpp 114583de8c867495a2b7a953e6826708838e5d23 src/tests/fault_tolerance_tests.cpp c63599ad36d883d25a23f5bab1929c4e2dad4960 src/tests/hierarchical_allocator_tests.cpp 9748ca0b3fee25dcec51c64d8ba84dbd4aaf src/tests/master_allocator_tests.cpp 89331965553505f6b7eebf39ad27d943df816a24 src/tests/master_authorization_tests.cpp f3f0cc81ab958e5b9a2bc458f5c38b3e12202514 src/tests/master_tests.cpp a4703afc331244a9e959c48652342f31ef787288 src/tests/mesos.hpp 64987f0cc1632eb8b0c2cccd8446a5324127910c src/tests/mesos.cpp 9bff4a66604a67d9add5a05247548e0162f3cda7 src/tests/partition_tests.cpp b7030adcfb1bfb128040aff20f12461412b5382c src/tests/rate_limiting_tests.cpp f3aeddee00c7bb7905092aa8a760603468063126 src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b src/tests/resource_offers_tests.cpp 882a9ff4d09aace486182828bf43b643b0d0c519 src/tests/scheduler_driver_tests.cpp 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 src/tests/scheduler_tests.cpp 7842f27673cc0fc11864916dda4ca4bbb66d9dbd src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc src/tests/sorter_tests.cpp 0db9a046007c1e89edb2af1e5d63cbc40934e2af Diff: https://reviews.apache.org/r/37468/diff/ Testing --- Thanks, Jose Guilherme Vanz
Re: Review Request 37468: Removed allocation types to mesos::master namespace
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37468/#review95418 --- Code looks good, but pls check what is wrong with the build - Guangya Liu On 八月 14, 2015, 2:01 a.m., José Guilherme Vanz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37468/ --- (Updated 八月 14, 2015, 2:01 a.m.) Review request for mesos. Bugs: MESOS-2516 https://issues.apache.org/jira/browse/MESOS-2516 Repository: mesos Description --- The allocation-related types was moved to mesos::master namespace. MESOS-2516 Diffs - docs/allocation-module.md 4ba5ba8c27cccebf0e5fc5064fdc1d6af05d38f0 include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 src/examples/test_allocator_module.cpp 9679fd9f9a998834bc5329efa07d46a0403ab3f6 src/local/local.hpp 6bb25f16982d7be067b5f1307d5eca7745820e81 src/local/local.cpp 4d98bf23705027f3ba0cbb571289f21b288fe7db src/master/allocator/allocator.cpp 42214048e83cb50bdb669d79fa49401c1716de87 src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659 src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629 src/master/allocator/sorter/drf/sorter.hpp f66ade06c6a5b4bf816839477cec2d18036c7b1a src/master/allocator/sorter/drf/sorter.cpp bfc273493419fe46a4d907f4f7fa282cff71b800 src/master/allocator/sorter/sorter.hpp 536a7ad9a2d661bc8aa352d2e0ae41115b1e8a04 src/master/main.cpp e024a2e4beeb58438accd07e1b87ea239fb1d88b src/master/master.hpp 1e12f650796acafcee83cf9bd0b85f57d359333c src/master/master.cpp c5e6c6f3304060d4c92d52851951f10bc432500e src/tests/cluster.hpp 114583de8c867495a2b7a953e6826708838e5d23 src/tests/fault_tolerance_tests.cpp c63599ad36d883d25a23f5bab1929c4e2dad4960 src/tests/hierarchical_allocator_tests.cpp 9748ca0b3fee25dcec51c64d8ba84dbd4aaf src/tests/master_allocator_tests.cpp 89331965553505f6b7eebf39ad27d943df816a24 src/tests/master_authorization_tests.cpp f3f0cc81ab958e5b9a2bc458f5c38b3e12202514 src/tests/master_tests.cpp a4703afc331244a9e959c48652342f31ef787288 src/tests/mesos.hpp 64987f0cc1632eb8b0c2cccd8446a5324127910c src/tests/mesos.cpp 9bff4a66604a67d9add5a05247548e0162f3cda7 src/tests/partition_tests.cpp b7030adcfb1bfb128040aff20f12461412b5382c src/tests/rate_limiting_tests.cpp f3aeddee00c7bb7905092aa8a760603468063126 src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b src/tests/resource_offers_tests.cpp 882a9ff4d09aace486182828bf43b643b0d0c519 src/tests/scheduler_driver_tests.cpp 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 src/tests/scheduler_tests.cpp 7842f27673cc0fc11864916dda4ca4bbb66d9dbd src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc src/tests/sorter_tests.cpp 0db9a046007c1e89edb2af1e5d63cbc40934e2af Diff: https://reviews.apache.org/r/37468/diff/ Testing --- Thanks, José Guilherme Vanz
Re: Review Request 37468: Removed allocation types to mesos::master namespace
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37468/#review95378 --- Bad patch! Reviews applied: [37468] Failed command: ./support/apply-review.sh -n -r 37468 Error: 2015-08-14 04:22:30 URL:https://reviews.apache.org/r/37468/diff/raw/ [23334/23334] - 37468.patch [1] Traceback (most recent call last): File ./support/jsonurl.py, line 25, in module print data UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 3: ordinal not in range(128) Successfully applied: Removed allocation types to mesos::master namespace The allocation-related types was moved to mesos::master namespace. MESOS-2516 Review: https://reviews.apache.org/r/37468 fatal: empty ident name (for guilherme@gmail.com) not allowed Failed to commit patch - Mesos ReviewBot On Aug. 14, 2015, 2:01 a.m., José Guilherme Vanz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37468/ --- (Updated Aug. 14, 2015, 2:01 a.m.) Review request for mesos. Bugs: MESOS-2516 https://issues.apache.org/jira/browse/MESOS-2516 Repository: mesos Description --- The allocation-related types was moved to mesos::master namespace. MESOS-2516 Diffs - docs/allocation-module.md 4ba5ba8c27cccebf0e5fc5064fdc1d6af05d38f0 include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 src/examples/test_allocator_module.cpp 9679fd9f9a998834bc5329efa07d46a0403ab3f6 src/local/local.hpp 6bb25f16982d7be067b5f1307d5eca7745820e81 src/local/local.cpp 4d98bf23705027f3ba0cbb571289f21b288fe7db src/master/allocator/allocator.cpp 42214048e83cb50bdb669d79fa49401c1716de87 src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659 src/master/allocator/mesos/hierarchical.hpp e278139f856888d6c6f538f7c0f664087e97f629 src/master/allocator/sorter/drf/sorter.hpp f66ade06c6a5b4bf816839477cec2d18036c7b1a src/master/allocator/sorter/drf/sorter.cpp bfc273493419fe46a4d907f4f7fa282cff71b800 src/master/allocator/sorter/sorter.hpp 536a7ad9a2d661bc8aa352d2e0ae41115b1e8a04 src/master/main.cpp e024a2e4beeb58438accd07e1b87ea239fb1d88b src/master/master.hpp 1e12f650796acafcee83cf9bd0b85f57d359333c src/master/master.cpp c5e6c6f3304060d4c92d52851951f10bc432500e src/tests/cluster.hpp 114583de8c867495a2b7a953e6826708838e5d23 src/tests/fault_tolerance_tests.cpp c63599ad36d883d25a23f5bab1929c4e2dad4960 src/tests/hierarchical_allocator_tests.cpp 9748ca0b3fee25dcec51c64d8ba84dbd4aaf src/tests/master_allocator_tests.cpp 89331965553505f6b7eebf39ad27d943df816a24 src/tests/master_authorization_tests.cpp f3f0cc81ab958e5b9a2bc458f5c38b3e12202514 src/tests/master_tests.cpp a4703afc331244a9e959c48652342f31ef787288 src/tests/mesos.hpp 64987f0cc1632eb8b0c2cccd8446a5324127910c src/tests/mesos.cpp 9bff4a66604a67d9add5a05247548e0162f3cda7 src/tests/partition_tests.cpp b7030adcfb1bfb128040aff20f12461412b5382c src/tests/rate_limiting_tests.cpp f3aeddee00c7bb7905092aa8a760603468063126 src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b src/tests/resource_offers_tests.cpp 882a9ff4d09aace486182828bf43b643b0d0c519 src/tests/scheduler_driver_tests.cpp 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 src/tests/scheduler_tests.cpp 7842f27673cc0fc11864916dda4ca4bbb66d9dbd src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc src/tests/sorter_tests.cpp 0db9a046007c1e89edb2af1e5d63cbc40934e2af Diff: https://reviews.apache.org/r/37468/diff/ Testing --- Thanks, José Guilherme Vanz
