Re: Review Request 37490: Convert CHECK functions to ADD_FAILURE in mesos.cpp to fail the test without aborting the test harness.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37490/ --- (Updated Aug. 14, 2015, 8:05 p.m.) Review request for mesos and Jie Yu. Changes --- Split review into two changes. Bugs: MESOS-3254 https://issues.apache.org/jira/browse/MESOS-3254 Repository: mesos Description --- Convert CHECK functions to ADD_FAILURE in mesos.cpp to fail the test without aborting the test harness. Diffs (updated) - src/tests/mesos.cpp 9bff4a66604a67d9add5a05247548e0162f3cda7 Diff: https://reviews.apache.org/r/37490/diff/ Testing --- sudo make check Thanks, Paul Brett
Review Request 37490: Convert CHECK functions to ADD_FAILURE in mesos.cpp to fail the test without aborting the test harness.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37490/ --- Review request for mesos and Jie Yu. Bugs: MESOS-3254 https://issues.apache.org/jira/browse/MESOS-3254 Repository: mesos Description --- Convert CHECK functions to ADD_FAILURE in mesos.cpp to fail the test without aborting the test harness. Diffs - src/tests/mesos.cpp 9bff4a66604a67d9add5a05247548e0162f3cda7 Diff: https://reviews.apache.org/r/37490/diff/ Testing --- sudo make check Thanks, Paul Brett
Re: Review Request 37490: Convert CHECK functions to ADD_FAILURE in mesos.cpp to fail the test without aborting the test harness.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37490/#review95480 --- Patch looks great! Reviews applied: [37490] All tests passed. - Mesos ReviewBot On Aug. 14, 2015, 8:05 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37490/ --- (Updated Aug. 14, 2015, 8:05 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-3254 https://issues.apache.org/jira/browse/MESOS-3254 Repository: mesos Description --- Convert CHECK functions to ADD_FAILURE in mesos.cpp to fail the test without aborting the test harness. Diffs - src/tests/mesos.cpp 9bff4a66604a67d9add5a05247548e0162f3cda7 Diff: https://reviews.apache.org/r/37490/diff/ Testing --- sudo make check Thanks, Paul Brett
