Re: Review Request 37559: Fixed mutex deadlock issue in ~scheduler::Mesos().

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37559/#review95666
---

Ship it!



src/scheduler/scheduler.cpp (lines 187 - 189)


This comment ended up confusing me further, seems to suggest that we 
ideally would be doing the await, but IMO it doesn't buy us anything?


- Ben Mahler


On Aug. 17, 2015, 11:29 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37559/
> ---
> 
> (Updated Aug. 17, 2015, 11:29 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3273
> https://issues.apache.org/jira/browse/MESOS-3273
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed the await on the mutex lock to avoid deadlock.
> 
> 
> Diffs
> -
> 
>   src/scheduler/scheduler.cpp d3d6682efdf4b5a6686bbe73a1e47e0559f7e309 
> 
> Diff: https://reviews.apache.org/r/37559/diff/
> 
> 
> Testing
> ---
> 
> Ran this test in repetition. It doesn't block here anymore, but there is 
> still another deadlock issue that I described in the bug.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Review Request 37559: Fixed mutex deadlock issue in ~scheduler::Mesos().

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37559/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-3273
https://issues.apache.org/jira/browse/MESOS-3273


Repository: mesos


Description
---

Removed the await on the mutex lock to avoid deadlock.


Diffs
-

  src/scheduler/scheduler.cpp d3d6682efdf4b5a6686bbe73a1e47e0559f7e309 

Diff: https://reviews.apache.org/r/37559/diff/


Testing
---

Ran this test in repetition. It doesn't block here anymore, but there is still 
another deadlock issue that I described in the bug.


Thanks,

Vinod Kone