Re: Review Request 37592: Added a defaultWindow to metrics based on LIBPROCESS_STATISTICS_WINDOW

2015-08-19 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37592/#review95840
---


Patch looks great!

Reviews applied: [37592]

All tests passed.

- Mesos ReviewBot


On Aug. 18, 2015, 10:25 p.m., Greg Mann wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37592/
 ---
 
 (Updated Aug. 18, 2015, 10:25 p.m.)
 
 
 Review request for mesos.
 
 
 Bugs: MESOS-1283
 https://issues.apache.org/jira/browse/MESOS-1283
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Added a defaultWindow to metrics based on LIBPROCESS_STATISTICS_WINDOW
 
 
 Diffs
 -
 
   3rdparty/libprocess/include/process/metrics/metrics.hpp 
 f2e84d8e62df58812b660c858eb3b0366db4 
   3rdparty/libprocess/src/metrics/metrics.cpp 
 b9617507a16318b7de25d4875d6bc0b4409fcd29 
   3rdparty/libprocess/src/process.cpp 
 755187c8761137cb2bf2f7295b29a63f63c68bc6 
   3rdparty/libprocess/src/tests/metrics_tests.cpp 
 29ed0330a498579896bbef3349572dd35299a40a 
 
 Diff: https://reviews.apache.org/r/37592/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Greg Mann
 




Review Request 37592: Added a defaultWindow to metrics based on LIBPROCESS_STATISTICS_WINDOW

2015-08-18 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37592/
---

Review request for mesos.


Bugs: MESOS-1283
https://issues.apache.org/jira/browse/MESOS-1283


Repository: mesos


Description
---

Added a defaultWindow to metrics based on LIBPROCESS_STATISTICS_WINDOW


Diffs
-

  3rdparty/libprocess/include/process/metrics/metrics.hpp 
f2e84d8e62df58812b660c858eb3b0366db4 
  3rdparty/libprocess/src/metrics/metrics.cpp 
b9617507a16318b7de25d4875d6bc0b4409fcd29 
  3rdparty/libprocess/src/process.cpp 755187c8761137cb2bf2f7295b29a63f63c68bc6 
  3rdparty/libprocess/src/tests/metrics_tests.cpp 
29ed0330a498579896bbef3349572dd35299a40a 

Diff: https://reviews.apache.org/r/37592/diff/


Testing
---

make check


Thanks,

Greg Mann