Re: Review Request 37856: Ensured that cgroups isolation is not used if multiple slaves are launched.

2015-08-27 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37856/#review96800
---

Ship it!


Ship It!


src/tests/environment.cpp 


Got it, just thought it's not related when I read the rb description.


- Timothy Chen


On Aug. 27, 2015, 9:06 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37856/
> ---
> 
> (Updated Aug. 27, 2015, 9:06 p.m.)
> 
> 
> Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ensured that cgroups isolation is not used if multiple slaves are launched.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.cpp 525347090f38b61f2085a2b2a6002d28d11b222f 
>   src/tests/event_call_framework_test.sh 
> 8eb3041b6a5d5d25c9f535b86b86a93b50e5e846 
>   src/tests/java_framework_test.sh 955fd8efbf52b7a3ac6bd8d38f7b1c5cc16b5654 
>   src/tests/no_executor_framework_test.sh 
> b5bb111ceb99d4dc836537516de57c1ba0582371 
>   src/tests/persistent_volume_framework_test.sh 
> c96fb707c4c05a21dac17c4e73d7fac3493f920e 
>   src/tests/python_framework_test.sh 2a322dac3c24027a76784b9bf026c7470465e84a 
>   src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc 
>   src/tests/test_framework_test.sh 209e9d87f07b3400e30784311e3df74cb7510c82 
> 
> Diff: https://reviews.apache.org/r/37856/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 37856: Ensured that cgroups isolation is not used if multiple slaves are launched.

2015-08-27 Thread Jie Yu 


> On Aug. 27, 2015, 9:58 p.m., Timothy Chen wrote:
> > src/tests/environment.cpp, line 298
> > 
> >
> > It works now?

See my change in MultipleSlaves test. Basically, I fixed the isolation used in 
that test so that port mapping isolator won't be used.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37856/#review96770
---


On Aug. 27, 2015, 9:06 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37856/
> ---
> 
> (Updated Aug. 27, 2015, 9:06 p.m.)
> 
> 
> Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ensured that cgroups isolation is not used if multiple slaves are launched.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.cpp 525347090f38b61f2085a2b2a6002d28d11b222f 
>   src/tests/event_call_framework_test.sh 
> 8eb3041b6a5d5d25c9f535b86b86a93b50e5e846 
>   src/tests/java_framework_test.sh 955fd8efbf52b7a3ac6bd8d38f7b1c5cc16b5654 
>   src/tests/no_executor_framework_test.sh 
> b5bb111ceb99d4dc836537516de57c1ba0582371 
>   src/tests/persistent_volume_framework_test.sh 
> c96fb707c4c05a21dac17c4e73d7fac3493f920e 
>   src/tests/python_framework_test.sh 2a322dac3c24027a76784b9bf026c7470465e84a 
>   src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc 
>   src/tests/test_framework_test.sh 209e9d87f07b3400e30784311e3df74cb7510c82 
> 
> Diff: https://reviews.apache.org/r/37856/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 37856: Ensured that cgroups isolation is not used if multiple slaves are launched.

2015-08-27 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37856/#review96775
---


Patch looks great!

Reviews applied: [37726, 37734, 37735, 37738, 37812, 37856]

All tests passed.

- Mesos ReviewBot


On Aug. 27, 2015, 9:06 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37856/
> ---
> 
> (Updated Aug. 27, 2015, 9:06 p.m.)
> 
> 
> Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ensured that cgroups isolation is not used if multiple slaves are launched.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.cpp 525347090f38b61f2085a2b2a6002d28d11b222f 
>   src/tests/event_call_framework_test.sh 
> 8eb3041b6a5d5d25c9f535b86b86a93b50e5e846 
>   src/tests/java_framework_test.sh 955fd8efbf52b7a3ac6bd8d38f7b1c5cc16b5654 
>   src/tests/no_executor_framework_test.sh 
> b5bb111ceb99d4dc836537516de57c1ba0582371 
>   src/tests/persistent_volume_framework_test.sh 
> c96fb707c4c05a21dac17c4e73d7fac3493f920e 
>   src/tests/python_framework_test.sh 2a322dac3c24027a76784b9bf026c7470465e84a 
>   src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc 
>   src/tests/test_framework_test.sh 209e9d87f07b3400e30784311e3df74cb7510c82 
> 
> Diff: https://reviews.apache.org/r/37856/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 37856: Ensured that cgroups isolation is not used if multiple slaves are launched.

2015-08-27 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37856/#review96770
---



src/tests/environment.cpp 


It works now?


- Timothy Chen


On Aug. 27, 2015, 9:06 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37856/
> ---
> 
> (Updated Aug. 27, 2015, 9:06 p.m.)
> 
> 
> Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ensured that cgroups isolation is not used if multiple slaves are launched.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.cpp 525347090f38b61f2085a2b2a6002d28d11b222f 
>   src/tests/event_call_framework_test.sh 
> 8eb3041b6a5d5d25c9f535b86b86a93b50e5e846 
>   src/tests/java_framework_test.sh 955fd8efbf52b7a3ac6bd8d38f7b1c5cc16b5654 
>   src/tests/no_executor_framework_test.sh 
> b5bb111ceb99d4dc836537516de57c1ba0582371 
>   src/tests/persistent_volume_framework_test.sh 
> c96fb707c4c05a21dac17c4e73d7fac3493f920e 
>   src/tests/python_framework_test.sh 2a322dac3c24027a76784b9bf026c7470465e84a 
>   src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc 
>   src/tests/test_framework_test.sh 209e9d87f07b3400e30784311e3df74cb7510c82 
> 
> Diff: https://reviews.apache.org/r/37856/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Review Request 37856: Ensured that cgroups isolation is not used if multiple slaves are launched.

2015-08-27 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37856/
---

Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.


Repository: mesos


Description
---

Ensured that cgroups isolation is not used if multiple slaves are launched.


Diffs
-

  src/tests/environment.cpp 525347090f38b61f2085a2b2a6002d28d11b222f 
  src/tests/event_call_framework_test.sh 
8eb3041b6a5d5d25c9f535b86b86a93b50e5e846 
  src/tests/java_framework_test.sh 955fd8efbf52b7a3ac6bd8d38f7b1c5cc16b5654 
  src/tests/no_executor_framework_test.sh 
b5bb111ceb99d4dc836537516de57c1ba0582371 
  src/tests/persistent_volume_framework_test.sh 
c96fb707c4c05a21dac17c4e73d7fac3493f920e 
  src/tests/python_framework_test.sh 2a322dac3c24027a76784b9bf026c7470465e84a 
  src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc 
  src/tests/test_framework_test.sh 209e9d87f07b3400e30784311e3df74cb7510c82 

Diff: https://reviews.apache.org/r/37856/diff/


Testing
---

sudo make check


Thanks,

Jie Yu