Re: Review Request 37955: Remove hashmap::existsValue since it is never called

2015-10-14 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37955/#review102720
---

Ship it!


Ship It!

- Vinod Kone


On Aug. 31, 2015, 3:42 p.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37955/
> ---
> 
> (Updated Aug. 31, 2015, 3:42 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3329
> https://issues.apache.org/jira/browse/MESOS-3329
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove hashmap::existsValue since it is never called
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp 
> f09bea125035aa3621402b83608b233e42877559 
> 
> Diff: https://reviews.apache.org/r/37955/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>



Re: Review Request 37955: Remove hashmap::existsValue since it is never called

2015-08-31 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37955/#review97154
---

Ship it!


Ship It!

- Guangya Liu


On 八月 31, 2015, 3:42 p.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37955/
> ---
> 
> (Updated 八月 31, 2015, 3:42 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3329
> https://issues.apache.org/jira/browse/MESOS-3329
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove hashmap::existsValue since it is never called
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp 
> f09bea125035aa3621402b83608b233e42877559 
> 
> Diff: https://reviews.apache.org/r/37955/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>



Re: Review Request 37955: Remove hashmap::existsValue since it is never called

2015-08-31 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37955/#review97086
---


Patch looks great!

Reviews applied: [37955]

All tests passed.

- Mesos ReviewBot


On Aug. 31, 2015, 3:42 p.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37955/
> ---
> 
> (Updated Aug. 31, 2015, 3:42 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3329
> https://issues.apache.org/jira/browse/MESOS-3329
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove hashmap::existsValue since it is never called
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp 
> f09bea125035aa3621402b83608b233e42877559 
> 
> Diff: https://reviews.apache.org/r/37955/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>



Review Request 37955: Remove hashmap::existsValue since it is never called

2015-08-31 Thread Jian Qiu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37955/
---

Review request for mesos.


Bugs: MESOS-3329
https://issues.apache.org/jira/browse/MESOS-3329


Repository: mesos


Description
---

Remove hashmap::existsValue since it is never called


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp 
f09bea125035aa3621402b83608b233e42877559 

Diff: https://reviews.apache.org/r/37955/diff/


Testing
---

make check


Thanks,

Jian Qiu