Re: Review Request 37969: Maintenance primitives: Tweak validation error messages to return JSON rather than protobuf.

2015-09-18 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37969/#review99555
---

Ship it!


Ship It!

- Joris Van Remoortere


On Sept. 15, 2015, 12:10 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37969/
> ---
> 
> (Updated Sept. 15, 2015, 12:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaces `__.DebugString()` with `stringify(JSON::Protobuf(__))`, which looks 
> nicer and matches the JSON expected by the HTTP endpoints.
> 
> Addresses a comment found here: 
> https://reviews.apache.org/r/37358/#comment152513
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
>   src/master/maintenance.cpp 87308a659db05f0676bd02a56ff41fe9d953ba71 
> 
> Diff: https://reviews.apache.org/r/37969/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> This change will tweak the output from:
> ```
> Machine 'hostname: "myComputer"
> ' is not valid because ...
> 
> ```
> (`DebugString` ^ puts a newline there.)
> 
> To: 
> ```
> Machine '{"hostname":"myComputer"}' is not valid because ...
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 37969: Maintenance primitives: Tweak validation error messages to return JSON rather than protobuf.

2015-09-15 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37969/#review99079
---


Patch looks great!

Reviews applied: [37969]

All tests passed.

- Mesos ReviewBot


On Sept. 15, 2015, 12:10 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37969/
> ---
> 
> (Updated Sept. 15, 2015, 12:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaces `__.DebugString()` with `stringify(JSON::Protobuf(__))`, which looks 
> nicer and matches the JSON expected by the HTTP endpoints.
> 
> Addresses a comment found here: 
> https://reviews.apache.org/r/37358/#comment152513
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
>   src/master/maintenance.cpp 87308a659db05f0676bd02a56ff41fe9d953ba71 
> 
> Diff: https://reviews.apache.org/r/37969/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> This change will tweak the output from:
> ```
> Machine 'hostname: "myComputer"
> ' is not valid because ...
> 
> ```
> (`DebugString` ^ puts a newline there.)
> 
> To: 
> ```
> Machine '{"hostname":"myComputer"}' is not valid because ...
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 37969: Maintenance primitives: Tweak validation error messages to return JSON rather than protobuf.

2015-09-14 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37969/
---

(Updated Sept. 14, 2015, 5:10 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
Remoortere.


Changes
---

Rebase.


Repository: mesos


Description
---

Replaces `__.DebugString()` with `stringify(JSON::Protobuf(__))`, which looks 
nicer and matches the JSON expected by the HTTP endpoints.

Addresses a comment found here: 
https://reviews.apache.org/r/37358/#comment152513


Diffs (updated)
-

  src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
  src/master/maintenance.cpp 87308a659db05f0676bd02a56ff41fe9d953ba71 

Diff: https://reviews.apache.org/r/37969/diff/


Testing
---

`make check`

This change will tweak the output from:
```
Machine 'hostname: "myComputer"
' is not valid because ...

```
(`DebugString` ^ puts a newline there.)

To: 
```
Machine '{"hostname":"myComputer"}' is not valid because ...
```


Thanks,

Joseph Wu



Review Request 37969: Maintenance primitives: Tweak validation error messages to return JSON rather than protobuf.

2015-08-31 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37969/
---

Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
Remoortere.


Repository: mesos


Description
---

Replaces `__.DebugString()` with `stringify(JSON::Protobuf(__))`, which looks 
nicer and matches the JSON expected by the HTTP endpoints.

Addresses a comment found here: 
https://reviews.apache.org/r/37358/#comment152513


Diffs
-

  src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e 
  src/master/maintenance.cpp 277dd8270fbd497616e5b24db4ea7dd615e170e3 

Diff: https://reviews.apache.org/r/37969/diff/


Testing
---

`make check`

This change will tweak the output from:
```
Machine 'hostname: "myComputer"
' is not valid because ...

```
(`DebugString` ^ puts a newline there.)

To: 
```
Machine '{"hostname":"myComputer"}' is not valid because ...
```


Thanks,

Joseph Wu



Re: Review Request 37969: Maintenance primitives: Tweak validation error messages to return JSON rather than protobuf.

2015-08-31 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37969/#review97202
---


Patch looks great!

Reviews applied: [37969]

All tests passed.

- Mesos ReviewBot


On Aug. 31, 2015, 9:42 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37969/
> ---
> 
> (Updated Aug. 31, 2015, 9:42 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaces `__.DebugString()` with `stringify(JSON::Protobuf(__))`, which looks 
> nicer and matches the JSON expected by the HTTP endpoints.
> 
> Addresses a comment found here: 
> https://reviews.apache.org/r/37358/#comment152513
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e 
>   src/master/maintenance.cpp 277dd8270fbd497616e5b24db4ea7dd615e170e3 
> 
> Diff: https://reviews.apache.org/r/37969/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> This change will tweak the output from:
> ```
> Machine 'hostname: "myComputer"
> ' is not valid because ...
> 
> ```
> (`DebugString` ^ puts a newline there.)
> 
> To: 
> ```
> Machine '{"hostname":"myComputer"}' is not valid because ...
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>