Re: Review Request 38075: Added an Appc provisioner recovery test.

2015-09-10 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38075/#review98448
---

Ship it!



src/tests/containerizer/appc_provisioner_tests.cpp (line 353)


Can you use a random containerId? I.e.,

UUID::random().toString();


- Jie Yu


On Sept. 10, 2015, 6:59 a.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38075/
> ---
> 
> (Updated Sept. 10, 2015, 6:59 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an Appc provisioner recovery test.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/appc_provisioner_tests.cpp 
> f30e1a1dee9a68be01133117339d91771f15988c 
> 
> Diff: https://reviews.apache.org/r/38075/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> This also utilizes the copy backend.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 38075: Added an Appc provisioner recovery test.

2015-09-10 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38075/#review98381
---


Patch looks great!

Reviews applied: [38239, 38240, 38241, 38075]

All tests passed.

- Mesos ReviewBot


On Sept. 10, 2015, 6:59 a.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38075/
> ---
> 
> (Updated Sept. 10, 2015, 6:59 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an Appc provisioner recovery test.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/appc_provisioner_tests.cpp 
> f30e1a1dee9a68be01133117339d91771f15988c 
> 
> Diff: https://reviews.apache.org/r/38075/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> This also utilizes the copy backend.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 38075: Added an Appc provisioner recovery test.

2015-09-10 Thread Jiang Yan Xu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38075/
---

(Updated Sept. 9, 2015, 11:59 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebased.


Repository: mesos


Description
---

Added an Appc provisioner recovery test.


Diffs (updated)
-

  src/tests/containerizer/appc_provisioner_tests.cpp 
f30e1a1dee9a68be01133117339d91771f15988c 

Diff: https://reviews.apache.org/r/38075/diff/


Testing
---

make check.

This also utilizes the copy backend.


Thanks,

Jiang Yan Xu

Re: Review Request 38075: Added an Appc provisioner recovery test.

2015-09-09 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38075/#review98353
---


Bad patch!

Reviews applied: [38239]

Failed command: ./support/apply-review.sh -n -r 38239

Error:
 2015-09-10 05:08:37 URL:https://reviews.apache.org/r/38239/diff/raw/ 
[2833/2833] -> "38239.patch" [1]
error: patch failed: src/Makefile.am:482
error: src/Makefile.am: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Sept. 10, 2015, 12:29 a.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38075/
> ---
> 
> (Updated Sept. 10, 2015, 12:29 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an Appc provisioner recovery test.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/appc_provisioner_tests.cpp 
> f30e1a1dee9a68be01133117339d91771f15988c 
> 
> Diff: https://reviews.apache.org/r/38075/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> This also utilizes the copy backend.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Review Request 38075: Added an Appc provisioner recovery test.

2015-09-09 Thread Jiang Yan Xu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38075/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Added an Appc provisioner recovery test.


Diffs
-

  src/tests/containerizer/appc_provisioner_tests.cpp 
f30e1a1dee9a68be01133117339d91771f15988c 

Diff: https://reviews.apache.org/r/38075/diff/


Testing
---

make check.

This also utilizes the copy backend.


Thanks,

Jiang Yan Xu