Re: Review Request 38164: Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.

2016-01-16 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38164/#review114852
---


Going to rebase this patch and use the newer primitive for this fix.

- Timothy Chen


On Jan. 16, 2016, 12:49 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38164/
> ---
> 
> (Updated Jan. 16, 2016, 12:49 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-3379
> https://issues.apache.org/jira/browse/MESOS-3379
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8823b7850a1ac17fc4f4868aadf1b04428d2381b 
> 
> Diff: https://reviews.apache.org/r/38164/diff/
> 
> 
> Testing
> ---
> 
> sudo GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="LinuxFilesystemIsolatorTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38164: Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.

2016-01-15 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38164/#review114819
---



src/slave/containerizer/isolators/filesystem/linux.cpp (line 820)


s/maybe/may/g 

I'll fix this myself


- Timothy Chen


On Jan. 16, 2016, 12:49 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38164/
> ---
> 
> (Updated Jan. 16, 2016, 12:49 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-3379
> https://issues.apache.org/jira/browse/MESOS-3379
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8823b7850a1ac17fc4f4868aadf1b04428d2381b 
> 
> Diff: https://reviews.apache.org/r/38164/diff/
> 
> 
> Testing
> ---
> 
> sudo GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="LinuxFilesystemIsolatorTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38164: Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.

2015-10-03 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38164/#review101420
---


Patch looks great!

Reviews applied: [38164]

All tests passed.

- Mesos ReviewBot


On Oct. 3, 2015, 4:17 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38164/
> ---
> 
> (Updated Oct. 3, 2015, 4:17 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Bugs: MESOS-3379
> https://issues.apache.org/jira/browse/MESOS-3379
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8823b7850a1ac17fc4f4868aadf1b04428d2381b 
> 
> Diff: https://reviews.apache.org/r/38164/diff/
> 
> 
> Testing
> ---
> 
> sudo GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="LinuxFilesystemIsolatorTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38164: Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.

2015-10-03 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38164/
---

(Updated Oct. 3, 2015, 4:17 p.m.)


Review request for mesos, Ian Downes and Jie Yu.


Changes
---

Rebase


Bugs: MESOS-3379
https://issues.apache.org/jira/browse/MESOS-3379


Repository: mesos


Description
---

Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.


Diffs (updated)
-

  src/slave/containerizer/isolators/filesystem/linux.cpp 
8823b7850a1ac17fc4f4868aadf1b04428d2381b 

Diff: https://reviews.apache.org/r/38164/diff/


Testing
---

sudo GLOG_v=1 ./bin/mesos-tests.sh 
--gtest_filter="LinuxFilesystemIsolatorTest.*" --verbose


Thanks,

haosdent huang

Re: Review Request 38164: Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.

2015-09-07 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38164/#review97941
---


Patch looks great!

Reviews applied: [38164]

All tests passed.

- Mesos ReviewBot


On Sept. 7, 2015, 6:26 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38164/
> ---
> 
> (Updated Sept. 7, 2015, 6:26 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-3379
> https://issues.apache.org/jira/browse/MESOS-3379
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 0970b3d48b13d5e9d2e0160df5cf14a3dcd0acc9 
> 
> Diff: https://reviews.apache.org/r/38164/diff/
> 
> 
> Testing
> ---
> 
> sudo GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="LinuxFilesystemIsolatorTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 38164: Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.

2015-09-07 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38164/
---

Review request for mesos, Ben Mahler and Jie Yu.


Bugs: MESOS-3379
https://issues.apache.org/jira/browse/MESOS-3379


Repository: mesos


Description
---

Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.


Diffs
-

  src/slave/containerizer/isolators/filesystem/linux.cpp 
0970b3d48b13d5e9d2e0160df5cf14a3dcd0acc9 

Diff: https://reviews.apache.org/r/38164/diff/


Testing
---

sudo GLOG_v=1 ./bin/mesos-tests.sh 
--gtest_filter="LinuxFilesystemIsolatorTest.*" --verbose


Thanks,

haosdent huang