Re: Review Request 38306: Libprocess: Removed namespace pollution from ssl gtest.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38306/#review98893
---

Ship it!



3rdparty/libprocess/include/process/ssl/gtest.hpp (lines 267 - 269)


An alternative formatting here would be:

```cpp
foreachpair (
const std::string& name, const std::string& value, environment) {
  os::setenv(name, value);
}
```

Up to you which one you like better :)


- Michael Park


On Sept. 11, 2015, 5:09 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38306/
> ---
> 
> (Updated Sept. 11, 2015, 5:09 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joseph Wu, Michael Park, and 
> Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This got introduced accidentally while factoring out common test
> fixtures.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/ssl/gtest.hpp 
> a6051b75f0a359ef1bc04e48444f9fd6da9a12dd 
> 
> Diff: https://reviews.apache.org/r/38306/diff/
> 
> 
> Testing
> ---
> 
> make check with and without ssl enabled.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 38306: Libprocess: Removed namespace pollution from ssl gtest.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38306/#review98654
---

Ship it!


LGTM.

Another general question:  Are there plans to move the logic in this file to a 
.cpp file?

- Joseph Wu


On Sept. 11, 2015, 10:09 a.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38306/
> ---
> 
> (Updated Sept. 11, 2015, 10:09 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joseph Wu, Michael Park, and 
> Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This got introduced accidentally while factoring out common test
> fixtures.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/ssl/gtest.hpp 
> a6051b75f0a359ef1bc04e48444f9fd6da9a12dd 
> 
> Diff: https://reviews.apache.org/r/38306/diff/
> 
> 
> Testing
> ---
> 
> make check with and without ssl enabled.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Review Request 38306: Libprocess: Removed namespace pollution from ssl gtest.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38306/
---

Review request for mesos, Artem Harutyunyan, Joseph Wu, Michael Park, and Till 
Toenshoff.


Repository: mesos


Description
---

This got introduced accidentally while factoring out common test
fixtures.


Diffs
-

  3rdparty/libprocess/include/process/ssl/gtest.hpp 
a6051b75f0a359ef1bc04e48444f9fd6da9a12dd 

Diff: https://reviews.apache.org/r/38306/diff/


Testing
---

make check with and without ssl enabled.


Thanks,

Joris Van Remoortere