Re: Review Request 38334: Added Labels field of FrameworkInfo into v1 mesos.proto

2015-09-14 Thread Adam B

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38334/#review98994
---

Ship it!


Ship It!

- Adam B


On Sept. 13, 2015, 6:45 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38334/
> ---
> 
> (Updated Sept. 13, 2015, 6:45 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3408
> https://issues.apache.org/jira/browse/MESOS-3408
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Labels field of FrameworkInfo into v1 mesos.proto
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto fdd678b329bd15b412d9460d24d29387d2945630 
> 
> Diff: https://reviews.apache.org/r/38334/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 38334: Added Labels field of FrameworkInfo into v1 mesos.proto

2015-09-13 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38334/#review98768
---


Patch looks great!

Reviews applied: [38334]

All tests passed.

- Mesos ReviewBot


On Sept. 13, 2015, 1:45 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38334/
> ---
> 
> (Updated Sept. 13, 2015, 1:45 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3408
> https://issues.apache.org/jira/browse/MESOS-3408
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Labels field of FrameworkInfo into v1 mesos.proto
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto fdd678b329bd15b412d9460d24d29387d2945630 
> 
> Diff: https://reviews.apache.org/r/38334/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 38334: Added Labels field of FrameworkInfo into v1 mesos.proto

2015-09-13 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38334/
---

(Updated Sept. 13, 2015, 9:45 p.m.)


Review request for mesos.


Bugs: MESOS-3408
https://issues.apache.org/jira/browse/MESOS-3408


Repository: mesos


Description
---

Added Labels field of FrameworkInfo into v1 mesos.proto


Diffs (updated)
-

  include/mesos/v1/mesos.proto fdd678b329bd15b412d9460d24d29387d2945630 

Diff: https://reviews.apache.org/r/38334/diff/


Testing
---

make check


Thanks,

Qian Zhang



Review Request 38334: Added Labels field of FrameworkInfo into v1 mesos.proto

2015-09-13 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38334/
---

Review request for mesos.


Bugs: MESOS-3408
https://issues.apache.org/jira/browse/MESOS-3408


Repository: mesos


Description
---

Added Labels field of FrameworkInfo into v1 mesos.proto


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 
7eb51e8771e95f57548fc35753e75c6d56cd97cd 
  3rdparty/libprocess/include/process/latch.hpp 
8a9d12165ea7442ddc68d20d15c8458b388bb679 
  3rdparty/libprocess/include/process/metrics/counter.hpp 
fd8be32dec79cb5ac372c80fcf4a581c8396c1b5 
  3rdparty/libprocess/include/process/process.hpp 
8b086f296c80a43be2edaf496a04dadf0c64251a 
  3rdparty/libprocess/src/clock.cpp 58060985bf8ab8a1bbd78b687b4c96836e13b86a 
  3rdparty/libprocess/src/latch.cpp f433a05236b2045127e2d22dfb375283b1e07a5d 
  3rdparty/libprocess/src/process.cpp 4afa30569b4d235637b49a624602e6b199c32e0e 
  3rdparty/libprocess/src/process_reference.hpp 
e6110bba2a54948be68e58ab9de988565b7d95a8 
  docs/mesos-c++-style-guide.md f1ed32aa845f7cfc85d002f4306a3c32e2eeb1d6 
  include/mesos/v1/mesos.proto fdd678b329bd15b412d9460d24d29387d2945630 
  src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1 
  src/sched/sched.cpp 1fc9e7351d090f751c92ad6f11ecc25cdf1255d2 
  src/tests/reservation_endpoints_tests.cpp 
dfab4971e04a81ac98ed118ea877bcca5db17bb5 

Diff: https://reviews.apache.org/r/38334/diff/


Testing
---

make check


Thanks,

Qian Zhang