Re: Review Request 38399: Add ACLs for the maintenance HTTP endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38399/#review105884 --- docs/authorization.md (line 12)

Re: Review Request 38399: Add ACLs for the maintenance HTTP endpoints

> On Sept. 18, 2015, 12:59 a.m., Joseph Wu wrote: > > docs/authentication.md, line 14 > > > > > > Are you sure this is correct? The ACL changes shouldn't change > > authentication, only authorization. This is used

Re: Review Request 38399: Add ACLs for the maintenance HTTP endpoints

> On Sept. 17, 2015, 8:44 p.m., Guangya Liu wrote: > > docs/authentication.md, line 14 > > > > > > There are four endpoints: > > /maintenance/schedule > > /maintenance/status > > /machine/down > >

Re: Review Request 38399: Add ACLs for the maintenance HTTP endpoints

> On Sept. 22, 2015, 3:58 p.m., Alexander Rojas wrote: > > src/authorizer/local/authorizer.cpp, lines 99-100 > > > > > > These lines could be joined. Thank you for poiting this, I will join them together in next

Re: Review Request 38399: Add ACLs for the maintenance HTTP endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38399/ --- (Updated Sept. 23, 2015, 1:16 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 38399: Add ACLs for the maintenance HTTP endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38399/ --- (Updated Sept. 17, 2015, 4:25 p.m.) Review request for mesos, Artem

Re: Review Request 38399: Add ACLs for the maintenance HTTP endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38399/#review99368 --- Patch looks great! Reviews applied: [38399] All tests passed. -

Re: Review Request 38399: Add ACLs for the maintenance HTTP endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38399/ --- (Updated Sept. 17, 2015, 4:31 p.m.) Review request for mesos, Artem

Re: Review Request 38399: Add ACLs for the maintenance HTTP endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38399/#review99376 --- I think that you also need some test cases for

Re: Review Request 38399: Add ACLs for the maintenance HTTP endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38399/#review99402 --- Note: I was hoping you would put changes in the docs and to the

Re: Review Request 38399: Add ACLs for the maintenance HTTP endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38399/#review99042 --- Thanks for picking this up! A few overall things that you missed

Review Request 38399: Add ACLs for the maintenance HTTP endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38399/ --- Review request for mesos. Bugs: mesos-