Re: Review Request 38451: Added test "ROOT_CommandTaskNoRootfsMultipleSameVolumes".

2016-05-03 Thread Guangya Liu
> On 五月 3, 2016, 9:42 p.m., Gilbert Song wrote: > > src/tests/containerizer/docker_volume_isolator_tests.cpp, line 440 > > > > > > Did you call the mock methods? No, the prepare() will be failed for such case before

Re: Review Request 38451: Added test "ROOT_CommandTaskNoRootfsMultipleSameVolumes".

2016-05-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38451/#review131566 --- src/tests/containerizer/docker_volume_isolator_tests.cpp (line 44

Re: Review Request 38451: Added test "ROOT_CommandTaskNoRootfsMultipleSameVolumes".

2016-05-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38451/#review131564 --- I am thinking we should only have one `ROOT_CommandTaskNoRootfsDoc

Re: Review Request 38451: Added test "ROOT_CommandTaskNoRootfsMultipleSameVolumes".

2016-05-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38451/#review131472 --- Patch looks great! Reviews applied: [46680, 46681, 46682, 46140,

Review Request 38451: Added test "ROOT_CommandTaskNoRootfsMultipleSameVolumes".

2016-05-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38451/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-5266 https:/