Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[haosdent huang]

> On Sept. 22, 2015, 6:21 a.m., Cong Wang wrote:
> > src/slave/containerizer/linux_launcher.cpp, line 182
> > 
> >
> > You forgot to remove this line?
> 
> haosdent huang wrote:
> sorry, my fault.

Let me create a new patch.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/#review99932
---


On Sept. 20, 2015, 5:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38535/
> ---
> 
> (Updated Sept. 20, 2015, 5:04 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ExamplesTest errors when user is root.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> dde552ff2a9d29c31f7676180fffa19d1fb0ba63 
> 
> Diff: https://reviews.apache.org/r/38535/diff/
> 
> 
> Testing
> ---
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[haosdent huang]

> On Sept. 22, 2015, 6:21 a.m., Cong Wang wrote:
> > src/slave/containerizer/linux_launcher.cpp, line 182
> > 
> >
> > You forgot to remove this line?

sorry, my fault.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/#review99932
---


On Sept. 20, 2015, 5:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38535/
> ---
> 
> (Updated Sept. 20, 2015, 5:04 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ExamplesTest errors when user is root.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> dde552ff2a9d29c31f7676180fffa19d1fb0ba63 
> 
> Diff: https://reviews.apache.org/r/38535/diff/
> 
> 
> Testing
> ---
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/#review99932
---



src/slave/containerizer/linux_launcher.cpp (line 182)


You forgot to remove this line?


There are two more places calling clone() in a similar way:  
src/tests/containerizer/launch_tests.cpp, src/tests/containerizer/ns_tests.cpp. 
Not sure if you need to fix them too.

- Cong Wang


On Sept. 20, 2015, 5:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38535/
> ---
> 
> (Updated Sept. 20, 2015, 5:04 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ExamplesTest errors when user is root.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> dde552ff2a9d29c31f7676180fffa19d1fb0ba63 
> 
> Diff: https://reviews.apache.org/r/38535/diff/
> 
> 
> Testing
> ---
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[haosdent huang]

On Sept. 22, 2015, 6:21 a.m., haosdent huang wrote:
> > There are two more places calling clone() in a similar way:  
> > src/tests/containerizer/launch_tests.cpp, 
> > src/tests/containerizer/ns_tests.cpp. Not sure if you need to fix them too.

Hi, @wangcong Thank you very much. I submit the patch here 
https://reviews.apache.org/r/38625/ Could you help review it again? Thank you 
in advance.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/#review99932
---


On Sept. 20, 2015, 5:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38535/
> ---
> 
> (Updated Sept. 20, 2015, 5:04 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ExamplesTest errors when user is root.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> dde552ff2a9d29c31f7676180fffa19d1fb0ba63 
> 
> Diff: https://reviews.apache.org/r/38535/diff/
> 
> 
> Testing
> ---
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[haosdent huang]

> On Sept. 21, 2015, 10:04 p.m., Jie Yu wrote:
> > OK, I'll address the comments for you since this is a blocker for the 
> > release.

Thank you very much.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/#review99839
---


On Sept. 20, 2015, 5:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38535/
> ---
> 
> (Updated Sept. 20, 2015, 5:04 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ExamplesTest errors when user is root.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> dde552ff2a9d29c31f7676180fffa19d1fb0ba63 
> 
> Diff: https://reviews.apache.org/r/38535/diff/
> 
> 
> Testing
> ---
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/#review99839
---


OK, I'll address the comments for you since this is a blocker for the release.

- Jie Yu


On Sept. 20, 2015, 5:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38535/
> ---
> 
> (Updated Sept. 20, 2015, 5:04 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ExamplesTest errors when user is root.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> dde552ff2a9d29c31f7676180fffa19d1fb0ba63 
> 
> Diff: https://reviews.apache.org/r/38535/diff/
> 
> 
> Testing
> ---
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/#review99840
---


commit 57361f10ccf1e026dbb691e67277cb0cb71c8ea6
Author: haosdent huang 
Date:   Mon Sep 21 14:27:34 2015 -0700

Allocated the stack used by clone dynamically.

This is to address the issue when running multiple slaves during tests.
The glibc 'clone' will modify the stack passed to it, therefore we
cannot use a shared stack.

Review: https://reviews.apache.org/r/38535

- Jie Yu


On Sept. 20, 2015, 5:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38535/
> ---
> 
> (Updated Sept. 20, 2015, 5:04 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ExamplesTest errors when user is root.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> dde552ff2a9d29c31f7676180fffa19d1fb0ba63 
> 
> Diff: https://reviews.apache.org/r/38535/diff/
> 
> 
> Testing
> ---
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/#review99764
---



src/slave/containerizer/linux_launcher.cpp (lines 184 - 186)


Could you please explain where the bug is in the description. I don't 
understand why this code is buggy.


- Jie Yu


On Sept. 20, 2015, 5:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38535/
> ---
> 
> (Updated Sept. 20, 2015, 5:04 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ExamplesTest errors when user is root.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> dde552ff2a9d29c31f7676180fffa19d1fb0ba63 
> 
> Diff: https://reviews.apache.org/r/38535/diff/
> 
> 
> Testing
> ---
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[haosdent huang]

> On Sept. 21, 2015, 5:16 p.m., Jie Yu wrote:
> > src/slave/containerizer/linux_launcher.cpp, lines 184-186
> > 
> >
> > Could you please explain where the bug is in the description. I don't 
> > understand why this code is buggy.

Because we have multi slaves, this share memory would be override in different 
threads. So that all threads would got the same "pipes" and same execute 
"function" pointer.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/#review99764
---


On Sept. 20, 2015, 5:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38535/
> ---
> 
> (Updated Sept. 20, 2015, 5:04 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ExamplesTest errors when user is root.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> dde552ff2a9d29c31f7676180fffa19d1fb0ba63 
> 
> Diff: https://reviews.apache.org/r/38535/diff/
> 
> 
> Testing
> ---
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[Jie Yu]

> On Sept. 21, 2015, 5:16 p.m., Jie Yu wrote:
> > src/slave/containerizer/linux_launcher.cpp, lines 184-186
> > 
> >
> > Could you please explain where the bug is in the description. I don't 
> > understand why this code is buggy.
> 
> haosdent huang wrote:
> Because we have multi slaves, this share memory would be override in 
> different threads. So that all threads would got the same "pipes" and same 
> execute "function" pointer.
> 
> haosdent huang wrote:
> And I some trace code here before, when we run LinuxLauncher parallels. 
> In clone method, the pointers to func are different. And then go into 
> childMain function, the pointers func become the last one. Only after change 
> to malloc a new stack in clone, the local variables in childMain would become 
> different.

Thanks haosdent! Just chatted with Kapil about this as well. Looks like glibc 
writes to the stack before calling system call 'clone'. That explains why it's 
problematic in multiple slave scenarios. Thanks for the patch. Mind adding some 
comments about why we need to do that? Thanks!


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/#review99764
---


On Sept. 20, 2015, 5:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38535/
> ---
> 
> (Updated Sept. 20, 2015, 5:04 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ExamplesTest errors when user is root.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> dde552ff2a9d29c31f7676180fffa19d1fb0ba63 
> 
> Diff: https://reviews.apache.org/r/38535/diff/
> 
> 
> Testing
> ---
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[haosdent huang]

> On Sept. 21, 2015, 5:16 p.m., Jie Yu wrote:
> > src/slave/containerizer/linux_launcher.cpp, lines 184-186
> > 
> >
> > Could you please explain where the bug is in the description. I don't 
> > understand why this code is buggy.
> 
> haosdent huang wrote:
> Because we have multi slaves, this share memory would be override in 
> different threads. So that all threads would got the same "pipes" and same 
> execute "function" pointer.

And I some trace code here before, when we run LinuxLauncher parallels. In 
clone method, the pointers to func are different. And then go into childMain 
function, the pointers func become the last one. Only after change to malloc a 
new stack in clone, the local variables in childMain would become different.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/#review99764
---


On Sept. 20, 2015, 5:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38535/
> ---
> 
> (Updated Sept. 20, 2015, 5:04 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ExamplesTest errors when user is root.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> dde552ff2a9d29c31f7676180fffa19d1fb0ba63 
> 
> Diff: https://reviews.apache.org/r/38535/diff/
> 
> 
> Testing
> ---
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/#review99829
---



src/slave/containerizer/linux_launcher.cpp (line 200)


Should this be the following?
```
delete[] stack;
```


- Jie Yu


On Sept. 20, 2015, 5:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38535/
> ---
> 
> (Updated Sept. 20, 2015, 5:04 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ExamplesTest errors when user is root.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> dde552ff2a9d29c31f7676180fffa19d1fb0ba63 
> 
> Diff: https://reviews.apache.org/r/38535/diff/
> 
> 
> Testing
> ---
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/#review99698
---


Patch looks great!

Reviews applied: [38535]

All tests passed.

- Mesos ReviewBot


On Sept. 20, 2015, 1:44 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38535/
> ---
> 
> (Updated Sept. 20, 2015, 1:44 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ExamplesTest errors when user is root.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> dde552ff2a9d29c31f7676180fffa19d1fb0ba63 
> 
> Diff: https://reviews.apache.org/r/38535/diff/
> 
> 
> Testing
> ---
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/#review99704
---

Ship it!


Thanks for the catch!! LGTM module the memory leak.


src/slave/containerizer/linux_launcher.cpp (line 199)


We need to free up the memory allocated above. It should be safe to do so 
after the clone call returns since it creates a new process.


- Kapil Arya


On Sept. 20, 2015, 12:08 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38535/
> ---
> 
> (Updated Sept. 20, 2015, 12:08 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ExamplesTest errors when user is root.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> dde552ff2a9d29c31f7676180fffa19d1fb0ba63 
> 
> Diff: https://reviews.apache.org/r/38535/diff/
> 
> 
> Testing
> ---
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/
---

(Updated Sept. 20, 2015, 4:08 p.m.)


Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and Michael 
Park.


Changes
---

Fix minor issues.


Bugs: MESOS-3474
https://issues.apache.org/jira/browse/MESOS-3474


Repository: mesos


Description
---

Fix ExamplesTest errors when user is root.


Diffs (updated)
-

  src/slave/containerizer/linux_launcher.cpp 
dde552ff2a9d29c31f7676180fffa19d1fb0ba63 

Diff: https://reviews.apache.org/r/38535/diff/


Testing
---

sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose


Thanks,

haosdent huang

Review Request 38535: Fix ExamplesTest errors when user is root.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/
---

Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park.


Bugs: MESOS-3474
https://issues.apache.org/jira/browse/MESOS-3474


Repository: mesos


Description
---

Fix ExamplesTest errors when user is root.


Diffs
-

  src/slave/containerizer/linux_launcher.cpp 
dde552ff2a9d29c31f7676180fffa19d1fb0ba63 

Diff: https://reviews.apache.org/r/38535/diff/


Testing
---

sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose


Thanks,

haosdent huang

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/#review99705
---


Patch looks great!

Reviews applied: [38535]

All tests passed.

- Mesos ReviewBot


On Sept. 20, 2015, 4:08 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38535/
> ---
> 
> (Updated Sept. 20, 2015, 4:08 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ExamplesTest errors when user is root.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> dde552ff2a9d29c31f7676180fffa19d1fb0ba63 
> 
> Diff: https://reviews.apache.org/r/38535/diff/
> 
> 
> Testing
> ---
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/#review99708
---


Patch looks great!

Reviews applied: [38535]

All tests passed.

- Mesos ReviewBot


On Sept. 20, 2015, 5:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38535/
> ---
> 
> (Updated Sept. 20, 2015, 5:04 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ExamplesTest errors when user is root.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> dde552ff2a9d29c31f7676180fffa19d1fb0ba63 
> 
> Diff: https://reviews.apache.org/r/38535/diff/
> 
> 
> Testing
> ---
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/
---

(Updated Sept. 20, 2015, 5:04 p.m.)


Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and Michael 
Park.


Changes
---

Update according @karya reviews.


Bugs: MESOS-3474
https://issues.apache.org/jira/browse/MESOS-3474


Repository: mesos


Description
---

Fix ExamplesTest errors when user is root.


Diffs (updated)
-

  src/slave/containerizer/linux_launcher.cpp 
dde552ff2a9d29c31f7676180fffa19d1fb0ba63 

Diff: https://reviews.apache.org/r/38535/diff/


Testing
---

sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose


Thanks,

haosdent huang