Re: Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

2015-09-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38550/#review100738 --- Ship it! - Joris Van Remoortere On Sept. 21, 2015, 10:43 a.m.,

Re: Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

2015-09-26 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38550/ --- (Updated Sept. 26, 2015, 10:03 p.m.) Review request for mesos, Artem

Re: Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

2015-09-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38550/#review100587 --- Ship it! Ship It! - haosdent huang On Sept. 21, 2015, 10:43

Re: Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

2015-09-25 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38550/#review100608 --- 3rdparty/libprocess/3rdparty/CMakeLists.txt (line 61)

Re: Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

2015-09-25 Thread Alex Clemmer
> On Sept. 25, 2015, 5:03 p.m., Artem Harutyunyan wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 61 > > > > > > 80+ characters? Per conversation with Joris, I think we'll probably keep this as is. -

Re: Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

2015-09-25 Thread Alex Clemmer
> On Sept. 25, 2015, 5:03 p.m., Artem Harutyunyan wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 61 > > > > > > 80+ characters? > > Alex Clemmer wrote: > Per conversation with Joris, I think we'll

Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

2015-09-21 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38550/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

2015-09-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38550/#review99743 --- Patch looks great! Reviews applied: [38456, 38457, 38529, 38530,

Re: Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

2015-09-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38550/#review99800 --- Ship it! Ship It! - Joseph Wu On Sept. 21, 2015, 3:43 a.m.,