Re: Review Request 38575: Added masterSlaveLostHook

2015-09-23 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38575/#review100308 --- Ship it! Ship It! - Joris Van Remoortere On Sept. 23, 2015, 10:

Re: Review Request 38575: Added masterSlaveLostHook

2015-09-23 Thread Niklas Nielsen
> On Sept. 21, 2015, 4:58 p.m., Guangya Liu wrote: > > include/mesos/hook.hpp, line 66 > > > > > > Do we need to update slave to agent in other comments introduced by > > this patch? All code references are now mark

Re: Review Request 38575: Added masterSlaveLostHook

2015-09-23 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38575/ --- (Updated Sept. 23, 2015, 3:24 p.m.) Review request for mesos, Joris Van Remoort

Re: Review Request 38575: Added masterSlaveLostHook

2015-09-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38575/#review100221 --- Ship it! Ship It! - haosdent huang On Sept. 21, 2015, 10:40 p.m

Re: Review Request 38575: Added masterSlaveLostHook

2015-09-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38575/#review99920 --- Patch looks great! Reviews applied: [38574, 38575] All tests passe

Re: Review Request 38575: Added masterSlaveLostHook

2015-09-21 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38575/#review99885 --- Ship it! LGTM module some minor language fixes for comments/log.

Re: Review Request 38575: Added masterSlaveLostHook

2015-09-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38575/#review99871 --- include/mesos/hook.hpp (line 66)

Re: Review Request 38575: Added masterSlaveLostHook

2015-09-21 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38575/ --- (Updated Sept. 21, 2015, 3:40 p.m.) Review request for mesos, Joris Van Remoort

Review Request 38575: Added masterSlaveLostHook

2015-09-21 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38575/ --- Review request for mesos, Joris Van Remoortere and Kapil Arya. Bugs: MESOS-3015