Re: Review Request 38636: Assign executors to `mesos_executor.slice` in LinuxLauncher on Systemd.

2015-09-23 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38636/
---

(Updated Sept. 24, 2015, 3:53 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas 
Nielsen, Thomas Rampelberg, and Timothy Chen.


Bugs: MESOS-3425
https://issues.apache.org/jira/browse/MESOS-3425


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/slave/containerizer/linux_launcher.cpp 
459af1b98ba577863d88d521f3ba8792959f42b4 

Diff: https://reviews.apache.org/r/38636/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 38636: Assign executors to `mesos_executor.slice` in LinuxLauncher on Systemd.

2015-09-23 Thread Benjamin Hindman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38636/#review100334
---

Ship it!



src/slave/containerizer/linux_launcher.cpp (line 349)


s/mesos_executors.slice/SYSTEMD_MESOS_EXECUTORS_SLICE/


- Benjamin Hindman


On Sept. 23, 2015, 8:34 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38636/
> ---
> 
> (Updated Sept. 23, 2015, 8:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas 
> Nielsen, Thomas Rampelberg, and Timothy Chen.
> 
> 
> Bugs: MESOS-3425
> https://issues.apache.org/jira/browse/MESOS-3425
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> 459af1b98ba577863d88d521f3ba8792959f42b4 
> 
> Diff: https://reviews.apache.org/r/38636/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 38636: Assign executors to `mesos_executor.slice` in LinuxLauncher on Systemd.

2015-09-23 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38636/
---

(Updated Sept. 23, 2015, 8:34 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas 
Nielsen, Thomas Rampelberg, and Timothy Chen.


Changes
---

rebased


Bugs: MESOS-3425
https://issues.apache.org/jira/browse/MESOS-3425


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/slave/containerizer/linux_launcher.cpp 
459af1b98ba577863d88d521f3ba8792959f42b4 

Diff: https://reviews.apache.org/r/38636/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 38636: Assign executors to `mesos_executor.slice` in LinuxLauncher on Systemd.

2015-09-22 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38636/
---

(Updated Sept. 23, 2015, 1:48 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas 
Nielsen, Thomas Rampelberg, and Timothy Chen.


Changes
---

Refactored based on BenH's comments.


Bugs: MESOS-3425
https://issues.apache.org/jira/browse/MESOS-3425


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/slave/containerizer/linux_launcher.cpp 
fd0ffcf838a745ccd458d57821d358eceb85be26 

Diff: https://reviews.apache.org/r/38636/diff/


Testing
---


Thanks,

Joris Van Remoortere

Review Request 38636: Assign executors to `mesos_executor.slice` in LinuxLauncher on Systemd.

2015-09-22 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38636/
---

Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas 
Nielsen, Thomas Rampelberg, and Timothy Chen.


Bugs: MESOS-3425
https://issues.apache.org/jira/browse/MESOS-3425


Repository: mesos


Description
---

See summary.


Diffs
-

  src/slave/containerizer/linux_launcher.cpp 
fd0ffcf838a745ccd458d57821d358eceb85be26 

Diff: https://reviews.apache.org/r/38636/diff/


Testing
---


Thanks,

Joris Van Remoortere