Re: Review Request 38653: Maintenance Primitives: Expose Accept/Decline responses for inverse offers through /maintenance/status

2015-09-23 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38653/#review100287
---

Ship it!


Ship It!

- Joris Van Remoortere


On Sept. 23, 2015, 3:55 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38653/
> ---
> 
> (Updated Sept. 23, 2015, 3:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3489
> https://issues.apache.org/jira/browse/MESOS-3489
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a `getInverseOfferStatuses` method to the allocator, which returns some 
> `InverseOfferStatus` objects, grouped by Agent and Framework.
> 
> Changes the `/maintenance/status` endpoint to return this additional 
> information about draining machines.
> 
> 
> Diffs
> -
> 
>   include/mesos/maintenance/maintenance.proto 
> ee01c5d29b792ca660c9dff90ea1c3f93ac6a492 
>   include/mesos/master/allocator.hpp 2fd00ca4f0ce6efa5ffb0af33bc4e791d66c04cc 
>   include/mesos/master/allocator.proto 
> b42f19def20ac3144e07144aece0da6873888b02 
>   src/common/protobuf_utils.hpp 3817c6a3374b2e8f333784261a0c8edabf854fd9 
>   src/common/protobuf_utils.cpp 4dc58fed315d99fd9cdde49e91eab1f4947ef046 
>   src/master/allocator/mesos/allocator.hpp 
> dca256598a19ccc83885af202554dfe21e3e6095 
>   src/master/allocator/mesos/hierarchical.hpp 
> 4ec08fd4f897fb0a4acb22a06ca69175ef7b9b55 
>   src/master/http.cpp 3e44b06eafa73c5eb4cd8cd90d9e7f14b3fc4e59 
>   src/master/master.cpp 90ef8c663c90ffbdcb4aa2377bfba65ea5d3fda9 
>   src/tests/master_maintenance_tests.cpp 
> c5277a13bd42e7e5d3c298f51823f12d31a6325f 
>   src/tests/mesos.hpp ff241cca567870f6dfd85bbe835754a4156c8874 
> 
> Diff: https://reviews.apache.org/r/38653/diff/
> 
> 
> Testing
> ---
> 
> `make check` (OSX clang 7.0)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 38653: Maintenance Primitives: Expose Accept/Decline responses for inverse offers through /maintenance/status

2015-09-23 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38653/#review100216
---


Patch looks great!

Reviews applied: [38653]

All tests passed.

- Mesos ReviewBot


On Sept. 23, 2015, 3:55 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38653/
> ---
> 
> (Updated Sept. 23, 2015, 3:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3489
> https://issues.apache.org/jira/browse/MESOS-3489
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a `getInverseOfferStatuses` method to the allocator, which returns some 
> `InverseOfferStatus` objects, grouped by Agent and Framework.
> 
> Changes the `/maintenance/status` endpoint to return this additional 
> information about draining machines.
> 
> 
> Diffs
> -
> 
>   include/mesos/maintenance/maintenance.proto 
> ee01c5d29b792ca660c9dff90ea1c3f93ac6a492 
>   include/mesos/master/allocator.hpp 2fd00ca4f0ce6efa5ffb0af33bc4e791d66c04cc 
>   include/mesos/master/allocator.proto 
> b42f19def20ac3144e07144aece0da6873888b02 
>   src/common/protobuf_utils.hpp 3817c6a3374b2e8f333784261a0c8edabf854fd9 
>   src/common/protobuf_utils.cpp 4dc58fed315d99fd9cdde49e91eab1f4947ef046 
>   src/master/allocator/mesos/allocator.hpp 
> dca256598a19ccc83885af202554dfe21e3e6095 
>   src/master/allocator/mesos/hierarchical.hpp 
> 4ec08fd4f897fb0a4acb22a06ca69175ef7b9b55 
>   src/master/http.cpp 3e44b06eafa73c5eb4cd8cd90d9e7f14b3fc4e59 
>   src/master/master.cpp 90ef8c663c90ffbdcb4aa2377bfba65ea5d3fda9 
>   src/tests/master_maintenance_tests.cpp 
> c5277a13bd42e7e5d3c298f51823f12d31a6325f 
>   src/tests/mesos.hpp ff241cca567870f6dfd85bbe835754a4156c8874 
> 
> Diff: https://reviews.apache.org/r/38653/diff/
> 
> 
> Testing
> ---
> 
> `make check` (OSX clang 7.0)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 38653: Maintenance Primitives: Expose Accept/Decline responses for inverse offers through /maintenance/status

2015-09-23 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38653/
---

(Updated Sept. 23, 2015, 8:55 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
Remoortere.


Changes
---

Addressed comments.  Thanks Qian Zhang & Joris!


Bugs: MESOS-3489
https://issues.apache.org/jira/browse/MESOS-3489


Repository: mesos


Description
---

Adds a `getInverseOfferStatuses` method to the allocator, which returns some 
`InverseOfferStatus` objects, grouped by Agent and Framework.

Changes the `/maintenance/status` endpoint to return this additional 
information about draining machines.


Diffs (updated)
-

  include/mesos/maintenance/maintenance.proto 
ee01c5d29b792ca660c9dff90ea1c3f93ac6a492 
  include/mesos/master/allocator.hpp 2fd00ca4f0ce6efa5ffb0af33bc4e791d66c04cc 
  include/mesos/master/allocator.proto b42f19def20ac3144e07144aece0da6873888b02 
  src/common/protobuf_utils.hpp 3817c6a3374b2e8f333784261a0c8edabf854fd9 
  src/common/protobuf_utils.cpp 4dc58fed315d99fd9cdde49e91eab1f4947ef046 
  src/master/allocator/mesos/allocator.hpp 
dca256598a19ccc83885af202554dfe21e3e6095 
  src/master/allocator/mesos/hierarchical.hpp 
4ec08fd4f897fb0a4acb22a06ca69175ef7b9b55 
  src/master/http.cpp 3e44b06eafa73c5eb4cd8cd90d9e7f14b3fc4e59 
  src/master/master.cpp 90ef8c663c90ffbdcb4aa2377bfba65ea5d3fda9 
  src/tests/master_maintenance_tests.cpp 
c5277a13bd42e7e5d3c298f51823f12d31a6325f 
  src/tests/mesos.hpp ff241cca567870f6dfd85bbe835754a4156c8874 

Diff: https://reviews.apache.org/r/38653/diff/


Testing
---

`make check` (OSX clang 7.0)


Thanks,

Joseph Wu

Re: Review Request 38653: Maintenance Primitives: Expose Accept/Decline responses for inverse offers through /maintenance/status

2015-09-22 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38653/#review100132
---


Patch looks great!

Reviews applied: [38653]

All tests passed.

- Mesos ReviewBot


On Sept. 22, 2015, 11:24 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38653/
> ---
> 
> (Updated Sept. 22, 2015, 11:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3489
> https://issues.apache.org/jira/browse/MESOS-3489
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a `getInverseOfferStatuses` method to the allocator, which returns some 
> `InverseOfferStatus` objects, grouped by Agent and Framework.
> 
> Changes the `/maintenance/status` endpoint to return this additional 
> information about draining machines.
> 
> 
> Diffs
> -
> 
>   include/mesos/maintenance/maintenance.proto 
> ee01c5d29b792ca660c9dff90ea1c3f93ac6a492 
>   include/mesos/master/allocator.hpp 2fd00ca4f0ce6efa5ffb0af33bc4e791d66c04cc 
>   include/mesos/master/allocator.proto 
> b42f19def20ac3144e07144aece0da6873888b02 
>   src/common/protobuf_utils.hpp 3817c6a3374b2e8f333784261a0c8edabf854fd9 
>   src/common/protobuf_utils.cpp 4dc58fed315d99fd9cdde49e91eab1f4947ef046 
>   src/master/allocator/mesos/allocator.hpp 
> dca256598a19ccc83885af202554dfe21e3e6095 
>   src/master/allocator/mesos/hierarchical.hpp 
> 4ec08fd4f897fb0a4acb22a06ca69175ef7b9b55 
>   src/master/http.cpp 3e44b06eafa73c5eb4cd8cd90d9e7f14b3fc4e59 
>   src/master/master.cpp 90ef8c663c90ffbdcb4aa2377bfba65ea5d3fda9 
>   src/tests/master_maintenance_tests.cpp 
> c5277a13bd42e7e5d3c298f51823f12d31a6325f 
>   src/tests/mesos.hpp ff241cca567870f6dfd85bbe835754a4156c8874 
> 
> Diff: https://reviews.apache.org/r/38653/diff/
> 
> 
> Testing
> ---
> 
> `make check` (OSX clang 7.0)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 38653: Maintenance Primitives: Expose Accept/Decline responses for inverse offers through /maintenance/status

2015-09-22 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38653/#review100125
---



src/master/http.cpp (line 1751)


Can you add a brief comment about the inverse offer statuses getting 
cleared if the master fails over

Here and around line 1772 where we implement the transformation.



src/tests/master_maintenance_tests.cpp (line 1231)


new line after we wrap the previous
same below.


- Joris Van Remoortere


On Sept. 22, 2015, 11:24 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38653/
> ---
> 
> (Updated Sept. 22, 2015, 11:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3489
> https://issues.apache.org/jira/browse/MESOS-3489
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a `getInverseOfferStatuses` method to the allocator, which returns some 
> `InverseOfferStatus` objects, grouped by Agent and Framework.
> 
> Changes the `/maintenance/status` endpoint to return this additional 
> information about draining machines.
> 
> 
> Diffs
> -
> 
>   include/mesos/maintenance/maintenance.proto 
> ee01c5d29b792ca660c9dff90ea1c3f93ac6a492 
>   include/mesos/master/allocator.hpp 2fd00ca4f0ce6efa5ffb0af33bc4e791d66c04cc 
>   include/mesos/master/allocator.proto 
> b42f19def20ac3144e07144aece0da6873888b02 
>   src/common/protobuf_utils.hpp 3817c6a3374b2e8f333784261a0c8edabf854fd9 
>   src/common/protobuf_utils.cpp 4dc58fed315d99fd9cdde49e91eab1f4947ef046 
>   src/master/allocator/mesos/allocator.hpp 
> dca256598a19ccc83885af202554dfe21e3e6095 
>   src/master/allocator/mesos/hierarchical.hpp 
> 4ec08fd4f897fb0a4acb22a06ca69175ef7b9b55 
>   src/master/http.cpp 3e44b06eafa73c5eb4cd8cd90d9e7f14b3fc4e59 
>   src/master/master.cpp 90ef8c663c90ffbdcb4aa2377bfba65ea5d3fda9 
>   src/tests/master_maintenance_tests.cpp 
> c5277a13bd42e7e5d3c298f51823f12d31a6325f 
>   src/tests/mesos.hpp ff241cca567870f6dfd85bbe835754a4156c8874 
> 
> Diff: https://reviews.apache.org/r/38653/diff/
> 
> 
> Testing
> ---
> 
> `make check` (OSX clang 7.0)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 38653: Maintenance Primitives: Expose Accept/Decline responses for inverse offers through /maintenance/status

2015-09-22 Thread Artem Harutyunyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38653/#review100123
---


Great job, Joris!

- Artem Harutyunyan


On Sept. 22, 2015, 4:24 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38653/
> ---
> 
> (Updated Sept. 22, 2015, 4:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3489
> https://issues.apache.org/jira/browse/MESOS-3489
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a `getInverseOfferStatuses` method to the allocator, which returns some 
> `InverseOfferStatus` objects, grouped by Agent and Framework.
> 
> Changes the `/maintenance/status` endpoint to return this additional 
> information about draining machines.
> 
> 
> Diffs
> -
> 
>   include/mesos/maintenance/maintenance.proto 
> ee01c5d29b792ca660c9dff90ea1c3f93ac6a492 
>   include/mesos/master/allocator.hpp 2fd00ca4f0ce6efa5ffb0af33bc4e791d66c04cc 
>   include/mesos/master/allocator.proto 
> b42f19def20ac3144e07144aece0da6873888b02 
>   src/common/protobuf_utils.hpp 3817c6a3374b2e8f333784261a0c8edabf854fd9 
>   src/common/protobuf_utils.cpp 4dc58fed315d99fd9cdde49e91eab1f4947ef046 
>   src/master/allocator/mesos/allocator.hpp 
> dca256598a19ccc83885af202554dfe21e3e6095 
>   src/master/allocator/mesos/hierarchical.hpp 
> 4ec08fd4f897fb0a4acb22a06ca69175ef7b9b55 
>   src/master/http.cpp 3e44b06eafa73c5eb4cd8cd90d9e7f14b3fc4e59 
>   src/master/master.cpp 90ef8c663c90ffbdcb4aa2377bfba65ea5d3fda9 
>   src/tests/master_maintenance_tests.cpp 
> c5277a13bd42e7e5d3c298f51823f12d31a6325f 
>   src/tests/mesos.hpp ff241cca567870f6dfd85bbe835754a4156c8874 
> 
> Diff: https://reviews.apache.org/r/38653/diff/
> 
> 
> Testing
> ---
> 
> `make check` (OSX clang 7.0)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 38653: Maintenance Primitives: Expose Accept/Decline responses for inverse offers through /maintenance/status

2015-09-22 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38653/#review100113
---



src/master/http.cpp (line 1775)


s/master->machines[id]/machine


- Qian Zhang


On Sept. 23, 2015, 7:24 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38653/
> ---
> 
> (Updated Sept. 23, 2015, 7:24 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3489
> https://issues.apache.org/jira/browse/MESOS-3489
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a `getInverseOfferStatuses` method to the allocator, which returns some 
> `InverseOfferStatus` objects, grouped by Agent and Framework.
> 
> Changes the `/maintenance/status` endpoint to return this additional 
> information about draining machines.
> 
> 
> Diffs
> -
> 
>   include/mesos/maintenance/maintenance.proto 
> ee01c5d29b792ca660c9dff90ea1c3f93ac6a492 
>   include/mesos/master/allocator.hpp 2fd00ca4f0ce6efa5ffb0af33bc4e791d66c04cc 
>   include/mesos/master/allocator.proto 
> b42f19def20ac3144e07144aece0da6873888b02 
>   src/common/protobuf_utils.hpp 3817c6a3374b2e8f333784261a0c8edabf854fd9 
>   src/common/protobuf_utils.cpp 4dc58fed315d99fd9cdde49e91eab1f4947ef046 
>   src/master/allocator/mesos/allocator.hpp 
> dca256598a19ccc83885af202554dfe21e3e6095 
>   src/master/allocator/mesos/hierarchical.hpp 
> 4ec08fd4f897fb0a4acb22a06ca69175ef7b9b55 
>   src/master/http.cpp 3e44b06eafa73c5eb4cd8cd90d9e7f14b3fc4e59 
>   src/master/master.cpp 90ef8c663c90ffbdcb4aa2377bfba65ea5d3fda9 
>   src/tests/master_maintenance_tests.cpp 
> c5277a13bd42e7e5d3c298f51823f12d31a6325f 
>   src/tests/mesos.hpp ff241cca567870f6dfd85bbe835754a4156c8874 
> 
> Diff: https://reviews.apache.org/r/38653/diff/
> 
> 
> Testing
> ---
> 
> `make check` (OSX clang 7.0)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 38653: Maintenance Primitives: Expose Accept/Decline responses for inverse offers through /maintenance/status

2015-09-22 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38653/#review100106
---

Ship it!


Ship It!

- Guangya Liu


On 九月 22, 2015, 11:24 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38653/
> ---
> 
> (Updated 九月 22, 2015, 11:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3489
> https://issues.apache.org/jira/browse/MESOS-3489
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a `getInverseOfferStatuses` method to the allocator, which returns some 
> `InverseOfferStatus` objects, grouped by Agent and Framework.
> 
> Changes the `/maintenance/status` endpoint to return this additional 
> information about draining machines.
> 
> 
> Diffs
> -
> 
>   include/mesos/maintenance/maintenance.proto 
> ee01c5d29b792ca660c9dff90ea1c3f93ac6a492 
>   include/mesos/master/allocator.hpp 2fd00ca4f0ce6efa5ffb0af33bc4e791d66c04cc 
>   include/mesos/master/allocator.proto 
> b42f19def20ac3144e07144aece0da6873888b02 
>   src/common/protobuf_utils.hpp 3817c6a3374b2e8f333784261a0c8edabf854fd9 
>   src/common/protobuf_utils.cpp 4dc58fed315d99fd9cdde49e91eab1f4947ef046 
>   src/master/allocator/mesos/allocator.hpp 
> dca256598a19ccc83885af202554dfe21e3e6095 
>   src/master/allocator/mesos/hierarchical.hpp 
> 4ec08fd4f897fb0a4acb22a06ca69175ef7b9b55 
>   src/master/http.cpp 3e44b06eafa73c5eb4cd8cd90d9e7f14b3fc4e59 
>   src/master/master.cpp 90ef8c663c90ffbdcb4aa2377bfba65ea5d3fda9 
>   src/tests/master_maintenance_tests.cpp 
> c5277a13bd42e7e5d3c298f51823f12d31a6325f 
>   src/tests/mesos.hpp ff241cca567870f6dfd85bbe835754a4156c8874 
> 
> Diff: https://reviews.apache.org/r/38653/diff/
> 
> 
> Testing
> ---
> 
> `make check` (OSX clang 7.0)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Review Request 38653: Maintenance Primitives: Expose Accept/Decline responses for inverse offers through /maintenance/status

2015-09-22 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38653/
---

Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van 
Remoortere.


Bugs: MESOS-3489
https://issues.apache.org/jira/browse/MESOS-3489


Repository: mesos


Description
---

Adds a `getInverseOfferStatuses` method to the allocator, which returns some 
`InverseOfferStatus` objects, grouped by Agent and Framework.

Changes the `/maintenance/status` endpoint to return this additional 
information about draining machines.


Diffs
-

  include/mesos/maintenance/maintenance.proto 
ee01c5d29b792ca660c9dff90ea1c3f93ac6a492 
  include/mesos/master/allocator.hpp 2fd00ca4f0ce6efa5ffb0af33bc4e791d66c04cc 
  include/mesos/master/allocator.proto b42f19def20ac3144e07144aece0da6873888b02 
  src/common/protobuf_utils.hpp 3817c6a3374b2e8f333784261a0c8edabf854fd9 
  src/common/protobuf_utils.cpp 4dc58fed315d99fd9cdde49e91eab1f4947ef046 
  src/master/allocator/mesos/allocator.hpp 
dca256598a19ccc83885af202554dfe21e3e6095 
  src/master/allocator/mesos/hierarchical.hpp 
4ec08fd4f897fb0a4acb22a06ca69175ef7b9b55 
  src/master/http.cpp 3e44b06eafa73c5eb4cd8cd90d9e7f14b3fc4e59 
  src/master/master.cpp 90ef8c663c90ffbdcb4aa2377bfba65ea5d3fda9 
  src/tests/master_maintenance_tests.cpp 
c5277a13bd42e7e5d3c298f51823f12d31a6325f 
  src/tests/mesos.hpp ff241cca567870f6dfd85bbe835754a4156c8874 

Diff: https://reviews.apache.org/r/38653/diff/


Testing
---

`make check` (OSX clang 7.0)


Thanks,

Joseph Wu