Re: Review Request 38665: Added fs::realpath().

[Joseph Wu]

> On Sept. 23, 2015, 10:37 a.m., Alex Clemmer wrote:
> > Can we add this test to the relevant CMakeLists.txt too?

It will be included :)

See the not-discarded review: https://reviews.apache.org/r/38667


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38665/#review100231
---


On Sept. 22, 2015, 11:38 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38665/
> ---
> 
> (Updated Sept. 22, 2015, 11:38 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-3499
> https://issues.apache.org/jira/browse/MESOS-3499
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> e64e3d9e958fab3c7c25fad17dcc2b279d255500 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 76e1674e08bbe65a4fdf86731823a61f231d6d12 
>   3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 
> 311b00b41398a9fd7374f3847190468ba59c1dc9 
>   3rdparty/libprocess/3rdparty/stout/tests/fs_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38665/diff/
> 
> 
> Testing
> ---
> 
> ./stout-tests
> 
> TODO(hartem): Test on OSX (At the time of writing this test the `master` on 
> OSX was broken).
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 38665: Added fs::realpath().

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38665/#review100231
---


Can we add this test to the relevant CMakeLists.txt too?

- Alex Clemmer


On Sept. 23, 2015, 6:38 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38665/
> ---
> 
> (Updated Sept. 23, 2015, 6:38 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-3499
> https://issues.apache.org/jira/browse/MESOS-3499
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> e64e3d9e958fab3c7c25fad17dcc2b279d255500 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 76e1674e08bbe65a4fdf86731823a61f231d6d12 
>   3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 
> 311b00b41398a9fd7374f3847190468ba59c1dc9 
>   3rdparty/libprocess/3rdparty/stout/tests/fs_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38665/diff/
> 
> 
> Testing
> ---
> 
> ./stout-tests
> 
> TODO(hartem): Test on OSX (At the time of writing this test the `master` on 
> OSX was broken).
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 38665: Added fs::realpath().

[Artem Harutyunyan]

> On Sept. 22, 2015, 11:35 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp, line 68
> > 
> >
> > what's the different between this and os::realpath?
> 
> Artem Harutyunyan wrote:
> You're right, there is none. I'll drop fs::realpath(). The test is still 
> valid though.

Thanks a lot for catching this!


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38665/#review100150
---


On Sept. 22, 2015, 11:38 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38665/
> ---
> 
> (Updated Sept. 22, 2015, 11:38 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-3499
> https://issues.apache.org/jira/browse/MESOS-3499
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> e64e3d9e958fab3c7c25fad17dcc2b279d255500 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 76e1674e08bbe65a4fdf86731823a61f231d6d12 
>   3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 
> 311b00b41398a9fd7374f3847190468ba59c1dc9 
>   3rdparty/libprocess/3rdparty/stout/tests/fs_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38665/diff/
> 
> 
> Testing
> ---
> 
> ./stout-tests
> 
> TODO(hartem): Test on OSX (At the time of writing this test the `master` on 
> OSX was broken).
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 38665: Added fs::realpath().

[Artem Harutyunyan]

> On Sept. 22, 2015, 11:35 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp, line 68
> > 
> >
> > what's the different between this and os::realpath?

You're right, there is none. I'll drop fs::realpath(). The test is still valid 
though.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38665/#review100150
---


On Sept. 22, 2015, 11:38 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38665/
> ---
> 
> (Updated Sept. 22, 2015, 11:38 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-3499
> https://issues.apache.org/jira/browse/MESOS-3499
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> e64e3d9e958fab3c7c25fad17dcc2b279d255500 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 76e1674e08bbe65a4fdf86731823a61f231d6d12 
>   3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 
> 311b00b41398a9fd7374f3847190468ba59c1dc9 
>   3rdparty/libprocess/3rdparty/stout/tests/fs_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38665/diff/
> 
> 
> Testing
> ---
> 
> ./stout-tests
> 
> TODO(hartem): Test on OSX (At the time of writing this test the `master` on 
> OSX was broken).
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 38665: Added fs::realpath().

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38665/
---

(Updated Sept. 22, 2015, 11:38 p.m.)


Review request for mesos, Joris Van Remoortere and Joseph Wu.


Changes
---

Whitespace.


Bugs: MESOS-3499
https://issues.apache.org/jira/browse/MESOS-3499


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/Makefile.am 
e64e3d9e958fab3c7c25fad17dcc2b279d255500 
  3rdparty/libprocess/3rdparty/stout/Makefile.am 
76e1674e08bbe65a4fdf86731823a61f231d6d12 
  3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 
311b00b41398a9fd7374f3847190468ba59c1dc9 
  3rdparty/libprocess/3rdparty/stout/tests/fs_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38665/diff/


Testing (updated)
---

./stout-tests

TODO(hartem): Test on OSX (At the time of writing this test the `master` on OSX 
was broken).


Thanks,

Artem Harutyunyan

Re: Review Request 38665: Added fs::realpath().

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38665/#review100151
---


Bad patch!

Reviews applied: [38665]

Failed command: ./support/apply-review.sh -n -r 38665

Error:
 2015-09-23 06:37:04 URL:https://reviews.apache.org/r/38665/diff/raw/ 
[3842/3842] -> "38665.patch" [1]
Successfully applied: Added fs::realpath().

See summary.


Review: https://reviews.apache.org/r/38665
Checking 2 files using filter 
--filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
3rdparty/libprocess/3rdparty/stout/tests/fs_tests.cpp:26:  Lines should be <= 
80 characters long  [whitespace/line_length] [2]
Total errors found: 1
ERROR: Commit spanning multiple projects.

Please use separate commits for mesos, libprocess and stout.

Paths grouped by project:
stout:
  3rdparty/libprocess/3rdparty/stout/Makefile.am
  3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp
  3rdparty/libprocess/3rdparty/stout/tests/fs_tests.cpp
libprocess:
  3rdparty/libprocess/3rdparty/Makefile.am
Failed to commit patch

- Mesos ReviewBot


On Sept. 23, 2015, 6:33 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38665/
> ---
> 
> (Updated Sept. 23, 2015, 6:33 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-3499
> https://issues.apache.org/jira/browse/MESOS-3499
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> e64e3d9e958fab3c7c25fad17dcc2b279d255500 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 76e1674e08bbe65a4fdf86731823a61f231d6d12 
>   3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 
> 311b00b41398a9fd7374f3847190468ba59c1dc9 
>   3rdparty/libprocess/3rdparty/stout/tests/fs_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38665/diff/
> 
> 
> Testing
> ---
> 
> ./stout-tests
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 38665: Added fs::realpath().

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38665/#review100150
---



3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp (line 68)


what's the different between this and os::realpath?


- Jie Yu


On Sept. 23, 2015, 6:33 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38665/
> ---
> 
> (Updated Sept. 23, 2015, 6:33 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-3499
> https://issues.apache.org/jira/browse/MESOS-3499
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> e64e3d9e958fab3c7c25fad17dcc2b279d255500 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 76e1674e08bbe65a4fdf86731823a61f231d6d12 
>   3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 
> 311b00b41398a9fd7374f3847190468ba59c1dc9 
>   3rdparty/libprocess/3rdparty/stout/tests/fs_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38665/diff/
> 
> 
> Testing
> ---
> 
> ./stout-tests
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Review Request 38665: Added fs::realpath().

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38665/
---

Review request for mesos, Joris Van Remoortere and Joseph Wu.


Bugs: MESOS-3499
https://issues.apache.org/jira/browse/MESOS-3499


Repository: mesos


Description
---

See summary.


Diffs
-

  3rdparty/libprocess/3rdparty/Makefile.am 
e64e3d9e958fab3c7c25fad17dcc2b279d255500 
  3rdparty/libprocess/3rdparty/stout/Makefile.am 
76e1674e08bbe65a4fdf86731823a61f231d6d12 
  3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 
311b00b41398a9fd7374f3847190468ba59c1dc9 
  3rdparty/libprocess/3rdparty/stout/tests/fs_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38665/diff/


Testing
---

./stout-tests


Thanks,

Artem Harutyunyan