Re: Review Request 38753: CMake: Transition Stout tests to use new third-party build scripts.

2015-09-26 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38753/
---

(Updated Sept. 26, 2015, 6 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

CMake: Transition Stout tests to use new third-party build scripts.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 
08325297ceb79b80c305ba4f2164ffd37591a0e8 

Diff: https://reviews.apache.org/r/38753/diff/


Testing
---

Compiled and ran made sure libprocess and stout tests ran and passed on the 
following platforms:

* OS X 10.10
* Ubuntu 14.04.2


Thanks,

Alex Clemmer

Re: Review Request 38753: CMake: Transition Stout tests to use new third-party build scripts.

2015-09-26 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38753/
---

(Updated Sept. 26, 2015, 10:05 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

CMake: Transition Stout tests to use new third-party build scripts.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 
08325297ceb79b80c305ba4f2164ffd37591a0e8 

Diff: https://reviews.apache.org/r/38753/diff/


Testing
---

Compiled and ran made sure libprocess and stout tests ran and passed on the 
following platforms:

* OS X 10.10
* Ubuntu 14.04.2


Thanks,

Alex Clemmer

Re: Review Request 38753: CMake: Transition Stout tests to use new third-party build scripts.

2015-09-25 Thread Artem Harutyunyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38753/#review100623
---


LGTM.

- Artem Harutyunyan


On Sept. 24, 2015, 11:19 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38753/
> ---
> 
> (Updated Sept. 24, 2015, 11:19 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Transition Stout tests to use new third-party build scripts.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 
> 08325297ceb79b80c305ba4f2164ffd37591a0e8 
> 
> Diff: https://reviews.apache.org/r/38753/diff/
> 
> 
> Testing
> ---
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the 
> following platforms:
> 
> * OS X 10.10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 38753: CMake: Transition Stout tests to use new third-party build scripts.

2015-09-25 Thread Alex Clemmer 


> On Sept. 25, 2015, 4:58 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake, lines 
> > 109-126
> > 
> >
> > Just to clarify.  You're getting rid of this because of haosdent's VS 
> > build script right?

Sorry, are you talking about the comment?

If so, yep, the comment is gone because of the VS build script.

If you're talking about the libraries here, those have been moved to 
convenience variables like `GLOG_INCLUDE_DIR`.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38753/#review100605
---


On Sept. 25, 2015, 6:19 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38753/
> ---
> 
> (Updated Sept. 25, 2015, 6:19 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Transition Stout tests to use new third-party build scripts.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 
> 08325297ceb79b80c305ba4f2164ffd37591a0e8 
> 
> Diff: https://reviews.apache.org/r/38753/diff/
> 
> 
> Testing
> ---
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the 
> following platforms:
> 
> * OS X 10.10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 38753: CMake: Transition Stout tests to use new third-party build scripts.

2015-09-25 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38753/#review100605
---

Ship it!



3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake (line 97)


Just to clarify.  You're getting rid of this because of haosdent's VS build 
script right?



3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake (lines 113 - 
117)


Looks like you don't need this comment anymore.


- Joseph Wu


On Sept. 24, 2015, 11:19 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38753/
> ---
> 
> (Updated Sept. 24, 2015, 11:19 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Transition Stout tests to use new third-party build scripts.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 
> 08325297ceb79b80c305ba4f2164ffd37591a0e8 
> 
> Diff: https://reviews.apache.org/r/38753/diff/
> 
> 
> Testing
> ---
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the 
> following platforms:
> 
> * OS X 10.10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Review Request 38753: CMake: Transition Stout tests to use new third-party build scripts.

2015-09-25 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38753/
---

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

CMake: Transition Stout tests to use new third-party build scripts.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 
08325297ceb79b80c305ba4f2164ffd37591a0e8 

Diff: https://reviews.apache.org/r/38753/diff/


Testing
---

Compiled and ran made sure libprocess and stout tests ran and passed on the 
following platforms:

* OS X 10.10
* Ubuntu 14.04.2


Thanks,

Alex Clemmer