subject:"Review Request 38910\: Added `\-v` flag to `docker rm`."

Re: Review Request 38910: Added `-v` flag to `docker rm`.

2015-10-07 Thread Mesos ReviewBot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38910/#review101812 --- Patch looks great! Reviews applied: [38910] All tests passed. -

Re: Review Request 38910: Added `-v` flag to `docker rm`.

2015-10-07 Thread Guangya Liu

> On 十月 1, 2015, 4:31 a.m., Jojy Varghese wrote: > > src/docker/docker.cpp, line 681 > > > > > > wondering this behavior should be defaulted or not. We might be > > overloading stop with more than what it should be

Re: Review Request 38910: Added `-v` flag to `docker rm`.

2015-10-07 Thread Greg Mann

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38910/ --- (Updated Oct. 7, 2015, 5:34 p.m.) Review request for mesos, Gilbert Song, Jojy

Re: Review Request 38910: Added `-v` flag to `docker rm`.

2015-10-06 Thread Greg Mann

> On Oct. 1, 2015, 4:31 a.m., Jojy Varghese wrote: > > src/docker/docker.cpp, line 681 > > > > > > wondering this behavior should be defaulted or not. We might be > > overloading stop with more than what it should

Re: Review Request 38910: Added `-v` flag to `docker rm`.

2015-10-06 Thread Timothy Chen

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38910/#review101743 --- src/docker/docker.cpp (line 681)

Re: Review Request 38910: Added `-v` flag to `docker rm`.

2015-10-06 Thread Greg Mann

> On Oct. 1, 2015, 4:31 a.m., Jojy Varghese wrote: > > src/docker/docker.cpp, line 681 > > > > > > wondering this behavior should be defaulted or not. We might be > > overloading stop with more than what it should

Re: Review Request 38910: Added `-v` flag to `docker rm`.

2015-10-06 Thread Guangya Liu

> On 十月 1, 2015, 4:31 a.m., Jojy Varghese wrote: > > src/docker/docker.cpp, line 681 > > > > > > wondering this behavior should be defaulted or not. We might be > > overloading stop with more than what it should be

Re: Review Request 38910: Added `-v` flag to `docker rm`.

2015-10-01 Thread Guangya Liu

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38910/#review101221 --- src/docker/docker.cpp (line 681)

Review Request 38910: Added `-v` flag to `docker rm`.

2015-09-30 Thread Greg Mann

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38910/ --- Review request for mesos, Gilbert Song, Jojy Varghese, and Timothy Chen. Bugs:

Re: Review Request 38910: Added `-v` flag to `docker rm`.

2015-09-30 Thread Mesos ReviewBot

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38910/#review101182 --- Patch looks great! Reviews applied: [38910] All tests passed. -

Re: Review Request 38910: Added `-v` flag to `docker rm`.

2015-09-30 Thread haosdent huang

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38910/#review101190 --- Ship it! Ship It! - haosdent huang On Sept. 30, 2015, 11:51