Re: Review Request 38932: Kill health check external command process and continue check after timeout.

2015-11-21 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38932/#review107497 --- Ship it! Ship It! - Timothy Chen On Oct. 5, 2015, 10:18 a.m.,

Re: Review Request 38932: Kill health check external command process and continue check after timeout.

2015-10-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38932/#review101564 --- Patch looks great! Reviews applied: [38932] All tests passed. -

Re: Review Request 38932: Kill health check external command process and continue check after timeout.

2015-10-05 Thread haosdent huang
> On Oct. 5, 2015, 10:03 a.m., Jan Schlicht wrote: > > src/health-check/main.cpp, line 208 > > > > > > Following the JIRA discussion, this change seems to be in line with > > Gabriels sentence "It's fine that the

Re: Review Request 38932: Kill health check external command process and continue check after timeout.

2015-10-05 Thread haosdent huang
> On Oct. 5, 2015, 10:03 a.m., Jan Schlicht wrote: > > src/health-check/main.cpp, line 208 > > > > > > Following the JIRA discussion, this change seems to be in line with > > Gabriels sentence "It's fine that the

Re: Review Request 38932: Kill health check external command process and continue check after timeout.

2015-10-05 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38932/#review101459 --- Ship it! src/health-check/main.cpp (line 208)

Re: Review Request 38932: Kill health check external command process and continue check after timeout.

2015-10-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38932/ --- (Updated Oct. 3, 2015, 1:26 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38932: Kill health check external command process and continue check after timeout.

2015-10-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38932/#review101404 --- Patch looks great! Reviews applied: [38932] All tests passed. -

Review Request 38932: Kill health check external command process and continue check after timeout.

2015-10-01 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38932/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-3479

Re: Review Request 38932: Kill health check external command process and continue check after timeout.

2015-10-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38932/#review101262 --- Patch looks great! Reviews applied: [38932] All tests passed. -