Re: Review Request 38952: Replaced `> >` with `>>` in fault tolerance tests.

2015-10-14 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38952/
---

(Updated Oct. 14, 2015, 3:51 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

Rebased.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/fault_tolerance_tests.cpp c97bc4691f9bac4a8677e6d2247be96ee9674b57 

Diff: https://reviews.apache.org/r/38952/diff/


Testing
---

make check (Mac OS 10.10.4)


Thanks,

Alexander Rukletsov



Re: Review Request 38952: Replaced `> >` with `>>` in fault tolerance tests.

2015-10-14 Thread Bernd Mathiske

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38952/#review102643
---

Ship it!


Ship It!

- Bernd Mathiske


On Oct. 14, 2015, 8:51 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38952/
> ---
> 
> (Updated Oct. 14, 2015, 8:51 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> c97bc4691f9bac4a8677e6d2247be96ee9674b57 
> 
> Diff: https://reviews.apache.org/r/38952/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Review Request 38952: Replaced `> >` with `>>` in fault tolerance tests.

2015-10-02 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38952/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/tests/fault_tolerance_tests.cpp c97bc4691f9bac4a8677e6d2247be96ee9674b57 

Diff: https://reviews.apache.org/r/38952/diff/


Testing
---

make check (Mac OS 10.10.4)


Thanks,

Alexander Rukletsov



Re: Review Request 38952: Replaced `> >` with `>>` in fault tolerance tests.

2015-10-02 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38952/#review101317
---


Bad patch!

Reviews applied: [38161, 38952]

Failed command: ./support/apply-review.sh -n -r 38952

Error:
 2015-10-02 13:28:39 URL:https://reviews.apache.org/r/38952/diff/raw/ 
[13279/13279] -> "38952.patch" [1]
error: patch failed: src/tests/fault_tolerance_tests.cpp:589
error: src/tests/fault_tolerance_tests.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Oct. 2, 2015, 1:26 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38952/
> ---
> 
> (Updated Oct. 2, 2015, 1:26 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> c97bc4691f9bac4a8677e6d2247be96ee9674b57 
> 
> Diff: https://reviews.apache.org/r/38952/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 38952: Replaced `> >` with `>>` in fault tolerance tests.

2015-10-02 Thread Alexander Rukletsov


> On Oct. 2, 2015, 3:01 p.m., Neil Conway wrote:
> > I agree this is an improvement, but rather than doing this piecemeal, why 
> > not do it once across the whole codebase?
> > 
> > Might also be worth adding to the style guide.

We have discussed that before and the agreement was not to do a sweep, but 
rather incrementally change when we touch appropriate files. See comments in 
https://reviews.apache.org/r/38161/ for reasoning for this patch.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38952/#review101323
---


On Oct. 2, 2015, 1:26 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38952/
> ---
> 
> (Updated Oct. 2, 2015, 1:26 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> c97bc4691f9bac4a8677e6d2247be96ee9674b57 
> 
> Diff: https://reviews.apache.org/r/38952/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 38952: Replaced `> >` with `>>` in fault tolerance tests.

2015-10-02 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38952/#review101323
---


I agree this is an improvement, but rather than doing this piecemeal, why not 
do it once across the whole codebase?

Might also be worth adding to the style guide.

- Neil Conway


On Oct. 2, 2015, 1:26 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38952/
> ---
> 
> (Updated Oct. 2, 2015, 1:26 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/fault_tolerance_tests.cpp 
> c97bc4691f9bac4a8677e6d2247be96ee9674b57 
> 
> Diff: https://reviews.apache.org/r/38952/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 38952: Replaced `> >` with `>>` in fault tolerance tests.

2015-10-02 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38952/
---

(Updated Oct. 2, 2015, 3:13 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

Rebased.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/fault_tolerance_tests.cpp c97bc4691f9bac4a8677e6d2247be96ee9674b57 

Diff: https://reviews.apache.org/r/38952/diff/


Testing
---

make check (Mac OS 10.10.4)


Thanks,

Alexander Rukletsov