Re: Review Request 38960: Add QuotaInfo Protobuf to CMake.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38960/#review101454 --- Ship it! Ship It! - Bernd Mathiske On Oct. 2, 2015, 9:51 a.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38960/ > --- > > (Updated Oct. 2, 2015, 9:51 a.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, > and Till Toenshoff. > > > Repository: mesos > > > Description > --- > > QuotaInfo was introduced here: https://reviews.apache.org/r/36908/ > > > Diffs > - > > src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983 > > Diff: https://reviews.apache.org/r/38960/diff/ > > > Testing > --- > > ``` > cmake .. # (OSX) > make -j8 | grep quota > ``` > > Confirmed that quota protobuf was built. > > > Thanks, > > Joseph Wu > >
Re: Review Request 38960: Add QuotaInfo Protobuf to CMake.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38960/#review101440 --- Ship it! Ship It! - Guangya Liu On 十月 2, 2015, 4:51 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38960/ > --- > > (Updated 十月 2, 2015, 4:51 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, > and Till Toenshoff. > > > Repository: mesos > > > Description > --- > > QuotaInfo was introduced here: https://reviews.apache.org/r/36908/ > > > Diffs > - > > src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983 > > Diff: https://reviews.apache.org/r/38960/diff/ > > > Testing > --- > > ``` > cmake .. # (OSX) > make -j8 | grep quota > ``` > > Confirmed that quota protobuf was built. > > > Thanks, > > Joseph Wu > >
Re: Review Request 38960: Add QuotaInfo Protobuf to CMake.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38960/#review101345 --- Ship it! Good catch, thanks Joseph! - Alexander Rukletsov On Oct. 2, 2015, 4:51 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38960/ > --- > > (Updated Oct. 2, 2015, 4:51 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, > and Till Toenshoff. > > > Repository: mesos > > > Description > --- > > QuotaInfo was introduced here: https://reviews.apache.org/r/36908/ > > > Diffs > - > > src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983 > > Diff: https://reviews.apache.org/r/38960/diff/ > > > Testing > --- > > ``` > cmake .. # (OSX) > make -j8 | grep quota > ``` > > Confirmed that quota protobuf was built. > > > Thanks, > > Joseph Wu > >
Re: Review Request 38960: Add QuotaInfo Protobuf to CMake.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38960/#review101342 --- Patch looks great! Reviews applied: [38960] All tests passed. - Mesos ReviewBot On Oct. 2, 2015, 4:51 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38960/ > --- > > (Updated Oct. 2, 2015, 4:51 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, > and Till Toenshoff. > > > Repository: mesos > > > Description > --- > > QuotaInfo was introduced here: https://reviews.apache.org/r/36908/ > > > Diffs > - > > src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983 > > Diff: https://reviews.apache.org/r/38960/diff/ > > > Testing > --- > > ``` > cmake .. # (OSX) > make -j8 | grep quota > ``` > > Confirmed that quota protobuf was built. > > > Thanks, > > Joseph Wu > >
Re: Review Request 38960: Add QuotaInfo Protobuf to CMake.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38960/#review101336 --- Ship it! Ship It! - Alex Clemmer On Oct. 2, 2015, 4:51 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38960/ > --- > > (Updated Oct. 2, 2015, 4:51 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, > and Till Toenshoff. > > > Repository: mesos > > > Description > --- > > QuotaInfo was introduced here: https://reviews.apache.org/r/36908/ > > > Diffs > - > > src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983 > > Diff: https://reviews.apache.org/r/38960/diff/ > > > Testing > --- > > ``` > cmake .. # (OSX) > make -j8 | grep quota > ``` > > Confirmed that quota protobuf was built. > > > Thanks, > > Joseph Wu > >
Re: Review Request 38960: Add QuotaInfo Protobuf to CMake.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38960/#review101335 --- Ship it! Ship It! - Gilbert Song On Oct. 2, 2015, 9:51 a.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38960/ > --- > > (Updated Oct. 2, 2015, 9:51 a.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, > and Till Toenshoff. > > > Repository: mesos > > > Description > --- > > QuotaInfo was introduced here: https://reviews.apache.org/r/36908/ > > > Diffs > - > > src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983 > > Diff: https://reviews.apache.org/r/38960/diff/ > > > Testing > --- > > ``` > cmake .. # (OSX) > make -j8 | grep quota > ``` > > Confirmed that quota protobuf was built. > > > Thanks, > > Joseph Wu > >
Review Request 38960: Add QuotaInfo Protobuf to CMake.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38960/ --- Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, and Till Toenshoff. Repository: mesos Description --- QuotaInfo was introduced here: https://reviews.apache.org/r/36908/ Diffs - src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983 Diff: https://reviews.apache.org/r/38960/diff/ Testing --- ``` cmake .. # (OSX) make -j8 | grep quota ``` Confirmed that quota protobuf was built. Thanks, Joseph Wu
