Re: Review Request 38977: Add reason for declineOffer

2015-10-12 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38977/#review102234
---


Patch looks great!

Reviews applied: [38977]

All tests passed.

- Mesos ReviewBot


On Oct. 12, 2015, 7:46 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38977/
> ---
> 
> (Updated Oct. 12, 2015, 7:46 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Joseph Wu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3041
> https://issues.apache.org/jira/browse/MESOS-3041
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since this depends on MESOS-3522, so this patch only update the
> interface and proto file.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
>   include/mesos/v1/scheduler/scheduler.proto 
> 871c2ef00b13eb93f65119096577ed45a95aead3 
>   src/sched/sched.cpp 724d7c0cef073342436de7cf5fe834fffbf0 
> 
> Diff: https://reviews.apache.org/r/38977/diff/
> 
> 
> Testing
> ---
> 
> Ubuntu 14.04
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Re: Review Request 38977: Add reason for declineOffer

2015-10-12 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38977/
---

(Updated 十月 12, 2015, 7:46 a.m.)


Review request for mesos, BenjaminVW BenjaminVW, Joseph Wu, and Vinod Kone.


Bugs: MESOS-3041
https://issues.apache.org/jira/browse/MESOS-3041


Repository: mesos


Description
---

Since this depends on MESOS-3522, so this patch only update the
interface and proto file.


Diffs (updated)
-

  include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
  include/mesos/v1/scheduler/scheduler.proto 
871c2ef00b13eb93f65119096577ed45a95aead3 
  src/sched/sched.cpp 724d7c0cef073342436de7cf5fe834fffbf0 

Diff: https://reviews.apache.org/r/38977/diff/


Testing
---

Ubuntu 14.04
make
make check


Thanks,

Guangya Liu



Re: Review Request 38977: Add reason for declineOffer

2015-10-11 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38977/
---

(Updated 十月 12, 2015, 5:34 a.m.)


Review request for mesos, BenjaminVW BenjaminVW, Joseph Wu, and Vinod Kone.


Bugs: MESOS-3041
https://issues.apache.org/jira/browse/MESOS-3041


Repository: mesos


Description
---

Since this depends on MESOS-3522, so this patch only update the
interface and proto file.


Diffs (updated)
-

  include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
  include/mesos/v1/scheduler/scheduler.proto 
871c2ef00b13eb93f65119096577ed45a95aead3 
  src/sched/sched.cpp 724d7c0cef073342436de7cf5fe834fffbf0 

Diff: https://reviews.apache.org/r/38977/diff/


Testing (updated)
---

Ubuntu 14.04
make
make check


Thanks,

Guangya Liu



Re: Review Request 38977: Add reason for declineOffer

2015-10-03 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38977/#review101427
---


Patch looks great!

Reviews applied: [38977]

All tests passed.

- Mesos ReviewBot


On Oct. 4, 2015, 3:20 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38977/
> ---
> 
> (Updated Oct. 4, 2015, 3:20 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Joseph Wu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3041
> https://issues.apache.org/jira/browse/MESOS-3041
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Since this depends on MESOS-3522, so this patch only update the
> interface and proto file.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
>   include/mesos/v1/scheduler/scheduler.proto 
> 871c2ef00b13eb93f65119096577ed45a95aead3 
>   src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d 
> 
> Diff: https://reviews.apache.org/r/38977/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Review Request 38977: Add reason for declineOffer

2015-10-03 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38977/
---

Review request for mesos, BenjaminVW BenjaminVW, Joseph Wu, and Vinod Kone.


Bugs: MESOS-3041
https://issues.apache.org/jira/browse/MESOS-3041


Repository: mesos


Description
---

Since this depends on MESOS-3522, so this patch only update the
interface and proto file.


Diffs
-

  include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
  include/mesos/v1/scheduler/scheduler.proto 
871c2ef00b13eb93f65119096577ed45a95aead3 
  src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d 

Diff: https://reviews.apache.org/r/38977/diff/


Testing
---


Thanks,

Guangya Liu