Re: Review Request 39056: Fix for Mesos master crash due to check failure.

> On Oct. 6, 2015, 5:42 p.m., Klaus Ma wrote: > > src/common/resources.cpp, line 879 > > > > > > This fix is ok for this ticket; but how to handle other part about > > cpu()? Here's some question from me: > >

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39056/#review107420 --- src/common/resources.cpp (lines 879 - 881)

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

> On Oct. 7, 2015, 1:03 a.m., Guangya Liu wrote: > > src/common/resources.cpp, line 879 > > > > > > The meos is now using 0.01 as the MIN_CPUS > > Guangya Liu wrote: > As the mesos is using 0.01 as the

Review Request 39056: Fix for Mesos master crash due to check failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39056/ --- Review request for mesos. Bugs: MESOS-3552

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39056/#review101674 --- src/common/resources.cpp (line 870)

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39056/#review101684 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39056/ --- (Updated Oct. 6, 2015, 9:33 p.m.) Review request for mesos and Neil Conway.

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

> On Oct. 6, 2015, 9:47 p.m., Jie Yu wrote: > > src/v1/resources.cpp, lines 880-886 > > > > > > Not yours, but too bad we need to duplicate the logic here. I am now > > sure what will be the long term plan here. If

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39056/#review101690 --- Ship it! Ship It! src/tests/reservation_tests.cpp (line 173)

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39056/#review101691 --- src/common/resources.cpp (line 876)

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

> On Oct. 6, 2015, 6:34 p.m., Neil Conway wrote: > > src/common/resources.cpp, line 874 > > > > > > This change should also be applied to Resources::apply() in > > src/v1/resources.cpp Thanks Neil. - Mandeep

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

> On Oct. 6, 2015, 9:47 p.m., Jie Yu wrote: > > src/common/resources.cpp, line 880 > > > > > > Can you introduce a `CHECK_DOUBLE_EQ` in `stout/check.hpp`, similar to > > > >

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39056/ --- (Updated Oct. 6, 2015, 10:07 p.m.) Review request for mesos and Neil Conway.

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

> On Oct. 6, 2015, 9:47 p.m., Jie Yu wrote: > > src/common/resources.cpp, line 880 > > > > > > Can you introduce a `CHECK_DOUBLE_EQ` in `stout/check.hpp`, similar to > > > >

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39056/#review101726 --- Patch looks great! Reviews applied: [39056] All tests passed. -

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39056/#review101727 --- src/common/resources.cpp (line 875)

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39056/#review101729 --- src/common/resources.cpp (line 875)

Re: Review Request 39056: Fix for Mesos master crash due to check failure.

> On 十月 7, 2015, 1:03 a.m., Guangya Liu wrote: > > src/common/resources.cpp, line 879 > > > > > > The meos is now using 0.01 as the MIN_CPUS As the mesos is using 0.01 as the MIN_CPUS, I think it is OK using 0.01