Re: Review Request 39186: added a FileDescriptor to manage the life cycle of fds.

2016-07-09 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39186/#review141492
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Oct. 9, 2015, 7:05 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39186/
> ---
> 
> (Updated Oct. 9, 2015, 7:05 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: mesos-3520
> https://issues.apache.org/jira/browse/mesos-3520
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> added a FileDescriptor to manage the life cycle of fds.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 
> 76e1674e08bbe65a4fdf86731823a61f231d6d12 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/filedescriptor.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
> 94292f8a46ec31bbaf6e52f48109322bbe123f70 
>   3rdparty/libprocess/3rdparty/stout/tests/os/filedescriptor_tests.cpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39186/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>



Review Request 39186: added a FileDescriptor to manage the life cycle of fds.

2015-10-09 Thread Chi Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39186/
---

Review request for mesos and Ben Mahler.


Bugs: mesos-3520
https://issues.apache.org/jira/browse/mesos-3520


Repository: mesos


Description
---

added a FileDescriptor to manage the life cycle of fds.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/Makefile.am 
76e1674e08bbe65a4fdf86731823a61f231d6d12 
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/filedescriptor.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 
94292f8a46ec31bbaf6e52f48109322bbe123f70 
  3rdparty/libprocess/3rdparty/stout/tests/os/filedescriptor_tests.cpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/39186/diff/


Testing
---


Thanks,

Chi Zhang