Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

2015-10-20 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39194/#review103220
---


Patch looks great!

Reviews applied: [39194]

All tests passed.

- Mesos ReviewBot


On Oct. 20, 2015, 12:42 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39194/
> ---
> 
> (Updated Oct. 20, 2015, 12:42 a.m.)
> 
> 
> Review request for mesos, Adam B and Dave Lester.
> 
> 
> Bugs: MESOS-3694
> https://issues.apache.org/jira/browse/MESOS-3694
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/site-docker/Dockerfile PRE-CREATION 
>   support/site-docker/README.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39194/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

2015-10-20 Thread Artem Harutyunyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39194/
---

(Updated Oct. 20, 2015, 1:51 p.m.)


Review request for mesos, Adam B and Dave Lester.


Changes
---

Addressed comments.


Bugs: MESOS-3694
https://issues.apache.org/jira/browse/MESOS-3694


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  support/site-docker/Dockerfile PRE-CREATION 
  support/site-docker/README.md PRE-CREATION 

Diff: https://reviews.apache.org/r/39194/diff/


Testing
---


Thanks,

Artem Harutyunyan

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

2015-10-20 Thread Artem Harutyunyan 


> On Oct. 20, 2015, 3:02 p.m., Adam B wrote:
> > support/site-docker/Dockerfile, line 3
> > 
> >
> > Where'd this version number come from? What does it mean? When do we 
> > increment it?

I removed the comment line.


> On Oct. 20, 2015, 3:02 p.m., Adam B wrote:
> > support/site-docker/Dockerfile, line 1
> > 
> >
> > Maybe we should use the official Apache license header?

Removed the comment. If you really feel it's necessary I can add the Apache 
license header. Please let me know.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39194/#review103315
---


On Oct. 20, 2015, 1:51 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39194/
> ---
> 
> (Updated Oct. 20, 2015, 1:51 p.m.)
> 
> 
> Review request for mesos, Adam B and Dave Lester.
> 
> 
> Bugs: MESOS-3694
> https://issues.apache.org/jira/browse/MESOS-3694
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/site-docker/Dockerfile PRE-CREATION 
>   support/site-docker/README.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39194/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

2015-10-20 Thread Artem Harutyunyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39194/
---

(Updated Oct. 20, 2015, 9:02 p.m.)


Review request for mesos, Adam B and Dave Lester.


Changes
---

Addressed comments.


Bugs: MESOS-3694
https://issues.apache.org/jira/browse/MESOS-3694


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  support/site-docker/Dockerfile PRE-CREATION 
  support/site-docker/README.md PRE-CREATION 

Diff: https://reviews.apache.org/r/39194/diff/


Testing
---


Thanks,

Artem Harutyunyan

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

2015-10-19 Thread Artem Harutyunyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39194/
---

(Updated Oct. 19, 2015, 5:42 p.m.)


Review request for mesos, Adam B and Dave Lester.


Changes
---

Addressing comments.


Bugs: MESOS-3694
https://issues.apache.org/jira/browse/MESOS-3694


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  support/site-docker/Dockerfile PRE-CREATION 
  support/site-docker/README.md PRE-CREATION 

Diff: https://reviews.apache.org/r/39194/diff/


Testing
---


Thanks,

Artem Harutyunyan

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

2015-10-19 Thread Artem Harutyunyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39194/
---

(Updated Oct. 19, 2015, 5:15 p.m.)


Review request for mesos and Adam B.


Changes
---

Addressed comments.


Bugs: MESOS-3694
https://issues.apache.org/jira/browse/MESOS-3694


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  support/site-docker/Dockerfile PRE-CREATION 
  support/site-docker/README.md PRE-CREATION 

Diff: https://reviews.apache.org/r/39194/diff/


Testing
---


Thanks,

Artem Harutyunyan

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

2015-10-19 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39194/#review103186
---



support/site-docker/README.md (line 13)


How about something like `` or `` 
instead of `/home/me/dev/mesos`?



support/site-docker/README.md (line 16)


`s/yout/your/`



support/site-docker/README.md (line 18)


`s/OSX/OS X/`
`docker VM` -- my guess is that this is referring to boot-to-docker stuff, 
might be worth mentioning it?


- Michael Park


On Oct. 20, 2015, 12:26 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39194/
> ---
> 
> (Updated Oct. 20, 2015, 12:26 a.m.)
> 
> 
> Review request for mesos, Adam B and Dave Lester.
> 
> 
> Bugs: MESOS-3694
> https://issues.apache.org/jira/browse/MESOS-3694
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/site-docker/Dockerfile PRE-CREATION 
>   support/site-docker/README.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39194/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

2015-10-19 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39194/#review103191
---

Ship it!


Ship It!

- Guangya Liu


On 十月 20, 2015, 12:42 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39194/
> ---
> 
> (Updated 十月 20, 2015, 12:42 a.m.)
> 
> 
> Review request for mesos, Adam B and Dave Lester.
> 
> 
> Bugs: MESOS-3694
> https://issues.apache.org/jira/browse/MESOS-3694
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/site-docker/Dockerfile PRE-CREATION 
>   support/site-docker/README.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39194/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

2015-10-09 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39194/#review102133
---



support/website/README.md (line 36)


Since this will live within the Mesos repo, this step can probably be 
omitted?


- Greg Mann


On Oct. 9, 2015, 10:43 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39194/
> ---
> 
> (Updated Oct. 9, 2015, 10:43 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3694
> https://issues.apache.org/jira/browse/MESOS-3694
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/website/Dockerfile PRE-CREATION 
>   support/website/README.md PRE-CREATION 
>   support/website/files/run_site.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39194/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

2015-10-09 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39194/#review102146
---


Patch looks great!

Reviews applied: [39194]

All tests passed.

- Mesos ReviewBot


On Oct. 9, 2015, 10:43 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39194/
> ---
> 
> (Updated Oct. 9, 2015, 10:43 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3694
> https://issues.apache.org/jira/browse/MESOS-3694
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/website/Dockerfile PRE-CREATION 
>   support/website/README.md PRE-CREATION 
>   support/website/files/run_site.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39194/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

2015-10-09 Thread Jonathon Rossi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39194/#review102126
---



support/website/files/run_site.sh (line 10)


With the changes we made you shouldn't pull from subversion anymore, the 
site files are in /site. Dave is yet to remove all the files from subversion 
other than the /publish directory.

The plan is to get everything going with the /publish directory manually 
committed to subversion and then work on removing subversion from the equation 
all together so pushing to git will cause the site to be built and deployed.


- Jonathon Rossi


On Oct. 9, 2015, 10:43 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39194/
> ---
> 
> (Updated Oct. 9, 2015, 10:43 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3694
> https://issues.apache.org/jira/browse/MESOS-3694
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/website/Dockerfile PRE-CREATION 
>   support/website/README.md PRE-CREATION 
>   support/website/files/run_site.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39194/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

2015-10-09 Thread Artem Harutyunyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39194/
---

Review request for mesos and Adam B.


Bugs: MESOS-3694
https://issues.apache.org/jira/browse/MESOS-3694


Repository: mesos


Description
---

See summary.


Diffs
-

  support/website/Dockerfile PRE-CREATION 
  support/website/README.md PRE-CREATION 
  support/website/files/run_site.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/39194/diff/


Testing
---


Thanks,

Artem Harutyunyan

Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.

2015-10-09 Thread Artem Harutyunyan 


> On Oct. 9, 2015, 3:52 p.m., Jonathon Rossi wrote:
> > support/website/files/run_site.sh, line 10
> > 
> >
> > With the changes we made you shouldn't pull from subversion anymore, 
> > the site files are in /site. Dave is yet to remove all the files from 
> > subversion other than the /publish directory.
> > 
> > The plan is to get everything going with the /publish directory 
> > manually committed to subversion and then work on removing subversion from 
> > the equation all together so pushing to git will cause the site to be built 
> > and deployed.

Thanks, I noticed 
https://git1-us-west.apache.org/repos/asf?p=mesos.git;a=commit;h=145dc90b127a76dbc0ced914e9c46a537aae903c
 just now. I'll make the changes (including the ones you proposed in the email 
on dev@ list).


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39194/#review102126
---


On Oct. 9, 2015, 3:43 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39194/
> ---
> 
> (Updated Oct. 9, 2015, 3:43 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3694
> https://issues.apache.org/jira/browse/MESOS-3694
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/website/Dockerfile PRE-CREATION 
>   support/website/README.md PRE-CREATION 
>   support/website/files/run_site.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39194/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>