Re: Review Request 39210: Windows: Moved `realpath` to its own file, `stout/os/realpath.hpp`.

2015-10-17 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39210/#review103039 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/os/wind

Re: Review Request 39210: Windows: Moved `realpath` to its own file, `stout/os/realpath.hpp`.

2015-10-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39210/#review102947 --- Ship it! Ship It! - Joseph Wu On Oct. 15, 2015, 1:31 p.m., Alex

Re: Review Request 39210: Windows: Moved `realpath` to its own file, `stout/os/realpath.hpp`.

2015-10-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39210/ --- (Updated Oct. 15, 2015, 8:31 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39210: Windows: Moved `realpath` to its own file, `stout/os/realpath.hpp`.

2015-10-13 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39210/ --- (Updated Oct. 13, 2015, 6:34 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39210: Windows: Moved `realpath` to its own file, `stout/os/realpath.hpp`.

2015-10-13 Thread Joseph Wu
> On Oct. 12, 2015, 2:29 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/realpath.hpp, line 25 > > > > > > Don't you need to include `windows.hpp` to get `PATH_MAX` (on Windows, > > of

Re: Review Request 39210: Windows: Moved `realpath` to its own file, `stout/os/realpath.hpp`.

2015-10-13 Thread Alex Clemmer
> On Oct. 12, 2015, 9:29 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/realpath.hpp, line 25 > > > > > > Don't you need to include `windows.hpp` to get `PATH_MAX` (on Windows, > > of

Re: Review Request 39210: Windows: Moved `realpath` to its own file, `stout/os/realpath.hpp`.

2015-10-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39210/#review102331 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/realpath.hpp (

Re: Review Request 39210: Windows: Moved `realpath` to its own file, `stout/os/realpath.hpp`.

2015-10-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39210/#review102180 --- Patch looks great! Reviews applied: [39019, 39076, 39091, 39092, 3

Re: Review Request 39210: Windows: Moved `realpath` to its own file, `stout/os/realpath.hpp`.

2015-10-10 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39210/ --- (Updated Oct. 11, 2015, 12:23 a.m.) Review request for mesos, Artem Harutyunyan

Review Request 39210: Windows: Moved `realpath` to its own file, `stout/os/realpath.hpp`.

2015-10-10 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39210/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu