Re: Review Request 39220: CMake: Added `slave/state.cpp` to Windows builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39220/ --- (Updated Oct. 19, 2015, 9:19 p.m.) Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, MESOS-3633, MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693 https://issues.apache.org/jira/browse/MESOS-3615 https://issues.apache.org/jira/browse/MESOS-3627 https://issues.apache.org/jira/browse/MESOS-3628 https://issues.apache.org/jira/browse/MESOS-3629 https://issues.apache.org/jira/browse/MESOS-3630 https://issues.apache.org/jira/browse/MESOS-3631 https://issues.apache.org/jira/browse/MESOS-3633 https://issues.apache.org/jira/browse/MESOS-3658 https://issues.apache.org/jira/browse/MESOS-3659 https://issues.apache.org/jira/browse/MESOS-3660 https://issues.apache.org/jira/browse/MESOS-3693 Repository: mesos Description --- CMake: Added `slave/state.cpp` to Windows builds. Diffs (updated) - CMakeLists.txt eb93b9491ed3a133808b237292b70d436779b776 src/CMakeLists.txt c85bddbda3a17b45d7e31517ddf70358ebde1b41 Diff: https://reviews.apache.org/r/39220/diff/ Testing --- Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15. Thanks, Alex Clemmer
Re: Review Request 39220: CMake: Added `slave/state.cpp` to Windows builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39220/#review102525 --- Ship it! Ship It! - Joseph Wu On Oct. 13, 2015, 11:36 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39220/ > --- > > (Updated Oct. 13, 2015, 11:36 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, > MESOS-3633, MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693 > https://issues.apache.org/jira/browse/MESOS-3615 > https://issues.apache.org/jira/browse/MESOS-3627 > https://issues.apache.org/jira/browse/MESOS-3628 > https://issues.apache.org/jira/browse/MESOS-3629 > https://issues.apache.org/jira/browse/MESOS-3630 > https://issues.apache.org/jira/browse/MESOS-3631 > https://issues.apache.org/jira/browse/MESOS-3633 > https://issues.apache.org/jira/browse/MESOS-3658 > https://issues.apache.org/jira/browse/MESOS-3659 > https://issues.apache.org/jira/browse/MESOS-3660 > https://issues.apache.org/jira/browse/MESOS-3693 > > > Repository: mesos > > > Description > --- > > CMake: Added `slave/state.cpp` to Windows builds. > > > Diffs > - > > CMakeLists.txt a5a66c13496a95bb7095504a4645909d887fb49f > src/CMakeLists.txt 536a99f3dc2f48e6002e70b605598f4d218a4324 > > Diff: https://reviews.apache.org/r/39220/diff/ > > > Testing > --- > > Built CMake solution and ran `make check` (or equivalent) on Windows 10, > Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on > Ubuntu 15. > > > Thanks, > > Alex Clemmer > >
Re: Review Request 39220: CMake: Added `slave/state.cpp` to Windows builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39220/ --- (Updated Oct. 13, 2015, 6:36 p.m.) Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, MESOS-3633, MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693 https://issues.apache.org/jira/browse/MESOS-3615 https://issues.apache.org/jira/browse/MESOS-3627 https://issues.apache.org/jira/browse/MESOS-3628 https://issues.apache.org/jira/browse/MESOS-3629 https://issues.apache.org/jira/browse/MESOS-3630 https://issues.apache.org/jira/browse/MESOS-3631 https://issues.apache.org/jira/browse/MESOS-3633 https://issues.apache.org/jira/browse/MESOS-3658 https://issues.apache.org/jira/browse/MESOS-3659 https://issues.apache.org/jira/browse/MESOS-3660 https://issues.apache.org/jira/browse/MESOS-3693 Repository: mesos Description --- CMake: Added `slave/state.cpp` to Windows builds. Diffs (updated) - CMakeLists.txt a5a66c13496a95bb7095504a4645909d887fb49f src/CMakeLists.txt 536a99f3dc2f48e6002e70b605598f4d218a4324 Diff: https://reviews.apache.org/r/39220/diff/ Testing --- Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15. Thanks, Alex Clemmer
Review Request 39220: CMake: Added `slave/state.cpp` to Windows builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39220/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, MESOS-3633, MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693 https://issues.apache.org/jira/browse/MESOS-3615 https://issues.apache.org/jira/browse/MESOS-3627 https://issues.apache.org/jira/browse/MESOS-3628 https://issues.apache.org/jira/browse/MESOS-3629 https://issues.apache.org/jira/browse/MESOS-3630 https://issues.apache.org/jira/browse/MESOS-3631 https://issues.apache.org/jira/browse/MESOS-3633 https://issues.apache.org/jira/browse/MESOS-3658 https://issues.apache.org/jira/browse/MESOS-3659 https://issues.apache.org/jira/browse/MESOS-3660 https://issues.apache.org/jira/browse/MESOS-3693 Repository: mesos Description --- CMake: Added `slave/state.cpp` to Windows builds. Diffs - CMakeLists.txt a5a66c13496a95bb7095504a4645909d887fb49f src/CMakeLists.txt 828dbb690841c561816811dfbb044aa3afead89d Diff: https://reviews.apache.org/r/39220/diff/ Testing --- Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15. Thanks, Alex Clemmer
Re: Review Request 39220: CMake: Added `slave/state.cpp` to Windows builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39220/#review102219 --- Patch looks great! Reviews applied: [39019, 39076, 39091, 39092, 39093, 39096, 39097, 39180, 39181, 39201, 39182, 39202, 39203, 39204, 39207, 39208, 39209, 39210, 39213, 39217, 39218, 39219, 39220] All tests passed. - Mesos ReviewBot On Oct. 12, 2015, 6:53 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39220/ > --- > > (Updated Oct. 12, 2015, 6:53 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, > MESOS-3633, MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693 > https://issues.apache.org/jira/browse/MESOS-3615 > https://issues.apache.org/jira/browse/MESOS-3627 > https://issues.apache.org/jira/browse/MESOS-3628 > https://issues.apache.org/jira/browse/MESOS-3629 > https://issues.apache.org/jira/browse/MESOS-3630 > https://issues.apache.org/jira/browse/MESOS-3631 > https://issues.apache.org/jira/browse/MESOS-3633 > https://issues.apache.org/jira/browse/MESOS-3658 > https://issues.apache.org/jira/browse/MESOS-3659 > https://issues.apache.org/jira/browse/MESOS-3660 > https://issues.apache.org/jira/browse/MESOS-3693 > > > Repository: mesos > > > Description > --- > > CMake: Added `slave/state.cpp` to Windows builds. > > > Diffs > - > > CMakeLists.txt a5a66c13496a95bb7095504a4645909d887fb49f > src/CMakeLists.txt 828dbb690841c561816811dfbb044aa3afead89d > > Diff: https://reviews.apache.org/r/39220/diff/ > > > Testing > --- > > Built CMake solution and ran `make check` (or equivalent) on Windows 10, > Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on > Ubuntu 15. > > > Thanks, > > Alex Clemmer > >
