Re: Review Request 39264: Windows:[3/3] Transitioned Mesos tests to use `os::raw` family.

2015-10-18 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39264/#review103066
---

Ship it!


- Joris Van Remoortere


On Oct. 13, 2015, 6:36 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39264/
> ---
> 
> (Updated Oct. 13, 2015, 6:36 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In the previous commits, we've added a family if wrapper functions in
> `os::raw` that allow us to get the environment variables of the
> executing process. This commit will transition the Mesos tests to use
> those functions.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.cpp df33a6b7962f915df63c78eb6632b67d8874cef5 
> 
> Diff: https://reviews.apache.org/r/39264/diff/
> 
> 
> Testing
> ---
> 
> `make check` on Ubuntu 15, OS X 10.10, and running the `check` project on 
> Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 39264: Windows:[3/3] Transitioned Mesos tests to use `os::raw` family.

2015-10-13 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39264/#review102529
---

Ship it!


Ship It!

- Joseph Wu


On Oct. 13, 2015, 11:36 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39264/
> ---
> 
> (Updated Oct. 13, 2015, 11:36 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In the previous commits, we've added a family if wrapper functions in
> `os::raw` that allow us to get the environment variables of the
> executing process. This commit will transition the Mesos tests to use
> those functions.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.cpp df33a6b7962f915df63c78eb6632b67d8874cef5 
> 
> Diff: https://reviews.apache.org/r/39264/diff/
> 
> 
> Testing
> ---
> 
> `make check` on Ubuntu 15, OS X 10.10, and running the `check` project on 
> Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 39264: Windows:[3/3] Transitioned Mesos tests to use `os::raw` family.

2015-10-13 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39264/
---

(Updated Oct. 13, 2015, 6:36 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

In the previous commits, we've added a family if wrapper functions in
`os::raw` that allow us to get the environment variables of the
executing process. This commit will transition the Mesos tests to use
those functions.


Diffs (updated)
-

  src/tests/environment.cpp df33a6b7962f915df63c78eb6632b67d8874cef5 

Diff: https://reviews.apache.org/r/39264/diff/


Testing
---

`make check` on Ubuntu 15, OS X 10.10, and running the `check` project on 
Windows 10.


Thanks,

Alex Clemmer